Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gradle mention from ReadMe to improve clarity #4178

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

AndrewGable
Copy link
Contributor

Details

Makes the Android setup a bit more clear that you do not need to run anything related to gradle to install dependencies.

Fixed Issues

N/A

Tests

N/A

@AndrewGable AndrewGable self-assigned this Jul 22, 2021
@AndrewGable AndrewGable requested a review from a team as a code owner July 22, 2021 19:05
@MelvinBot MelvinBot requested review from stitesExpensify and removed request for a team July 22, 2021 19:06
Copy link
Contributor

@TomatoToaster TomatoToaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have also been confused by this, I think it's a great change 👍

Copy link
Contributor

@aldo-expensify aldo-expensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@AndrewGable AndrewGable merged commit 6059660 into main Jul 22, 2021
@AndrewGable AndrewGable deleted the andrew-readme-gradle branch July 22, 2021 19:40
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.79-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.80-2🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants