Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Enable default context-menu on messages being edited #4179

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Fix: Enable default context-menu on messages being edited #4179

merged 1 commit into from
Jul 26, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jul 22, 2021 •
edited
Loading

Details

Fixed Issues

$ #4107

Tests | QA Steps

  1. Open e.cash app in Desktop
  2. Navigate to a conversation
  3. Send a message with a grammar mistake
  4. Edit the same message
  5. Try to use word recommendation on the misspelled word.
  1. Open e.cash app in Desktop
  2. Navigate to a conversation
  3. Edit any old message
  4. Right-click the edit box to see the default context menu.
  5. Now right-click any other message which is not being edited, App's customized Context-menu should be shown.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

right-click.mp4

@parasharrajat parasharrajat requested a review from a team as a code owner July 22, 2021 20:43
@MelvinBot MelvinBot requested review from deetergp and removed request for a team July 22, 2021 20:43
@parasharrajat parasharrajat mentioned this pull request Jul 22, 2021
Closed
deetergp
deetergp approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@deetergp deetergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and fix works well on web & desktop. Thanks!

Screen Shot 2021-07-26 at 10 04 28 AM

Screen Shot 2021-07-26 at 10 09 11 AM

@deetergp deetergp merged commit 59c393d into Expensify:main Jul 26, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

This was referenced Jul 27, 2021
Closed
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.80-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.81-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the right-click branch November 20, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deetergp deetergp deetergp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parasharrajat @OSBotify @deetergp