[No QA] Use Hermes on iOS #4183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use hermes use number format for iOS too undo changes undo some changes undo flipper stuff undo other changes undo report.js changes
marcaaron
force-pushed
the
marcaaron-flipperNetwork
branch
from
a63662c to
3f08a49
Compare
|
Testing pretty good for me so gonna put this into review. |
MonilBhavsar
approved these changes
Jul 26, 2021
AndrewGable
approved these changes
Jul 26, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was referenced Jul 27, 2021
|
🚀 Deployed to staging in version: 1.0.80-3🚀
|
|
@marcaaron Heyo! Any QA tests needed for this PR? |
|
Sorry, nothing besides normal regressions ! Thanks! |
|
🚀 Deployed to production in version: 1.0.81-4🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Switch to using Hermes engine on iOS.
Hermes build on the right
Hermes.mp4
Note There was one issue where the
Intlglobal we were using became unavailable. I don't think there's anything like this, but probably it was available in the previous engine, but not in Hermes. So we should probably watch out for any other things like that.Fixed Issues (Potential)
#4027
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android