Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA][TS Migration] Add comments for remaining properties in Onyx types #41956

Merged
merged 28 commits into from
Jun 7, 2024
Merged

[No QA][TS Migration] Add comments for remaining properties in Onyx types #41956

merged 28 commits into from
Jun 7, 2024

Commits on May 9, 2024

  1. docs: add onyx types descriptions

    @pac-guerreiro
    pac-guerreiro committed May 9, 2024
    Configuration menu
    Copy the full SHA
    5b9433c View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. docs: add missing onyx types descriptions

    @pac-guerreiro
    pac-guerreiro committed May 13, 2024
    Configuration menu
    Copy the full SHA
    4dac52f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into pac-guerreiro/refactor/39129-add-comments-to… 

    …-remaining-onyx-types

# Conflicts:
#	src/types/onyx/Policy.ts
#	src/types/onyx/Report.ts
#	src/types/onyx/ReportAction.ts
    @pac-guerreiro
    pac-guerreiro committed May 13, 2024
    Configuration menu
    Copy the full SHA
    ee11f2e View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Merge branch 'main' into pac-guerreiro/refactor/39129-add-comments-to… 

    …-remaining-onyx-types

# Conflicts:
#	src/types/onyx/IOU.ts
    @pac-guerreiro
    pac-guerreiro committed May 15, 2024
    Configuration menu
    Copy the full SHA
    8631fa8 View commit details
    Browse the repository at this point in the history

  2. docs: add missing type descriptions

    @pac-guerreiro
    pac-guerreiro committed May 15, 2024
    Configuration menu
    Copy the full SHA
    13029ae View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Merge branch 'main' into pac-guerreiro/refactor/39129-add-comments-to… 

    …-remaining-onyx-types
    @pac-guerreiro
    pac-guerreiro committed May 20, 2024
    Configuration menu
    Copy the full SHA
    3494545 View commit details
    Browse the repository at this point in the history

  2. docs: apply pull request suggestions

    @pac-guerreiro
    pac-guerreiro committed May 20, 2024
    Configuration menu
    Copy the full SHA
    96f6955 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. refactor: apply pull request suggestions

    @pac-guerreiro
    pac-guerreiro committed May 22, 2024
    Configuration menu
    Copy the full SHA
    65022fb View commit details
    Browse the repository at this point in the history

  2. refactor: apply pull request suggestions

    @pac-guerreiro
    pac-guerreiro committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f3e1c8f View commit details
    Browse the repository at this point in the history

  3. refactor: remove unused property from wallet additional details

    @pac-guerreiro
    pac-guerreiro committed May 22, 2024
    Configuration menu
    Copy the full SHA
    530d6d6 View commit details
    Browse the repository at this point in the history

  4. docs: add missing type description

    @pac-guerreiro
    pac-guerreiro committed May 22, 2024
    Configuration menu
    Copy the full SHA
    9a50d43 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Merge branch 'main' into pac-guerreiro/refactor/39129-add-comments-to… 

    …-remaining-onyx-types
    @pac-guerreiro
    pac-guerreiro committed May 24, 2024
    Configuration menu
    Copy the full SHA
    611266d View commit details
    Browse the repository at this point in the history

  2. chore: resolve pending descriptions

    @pac-guerreiro
    pac-guerreiro committed May 24, 2024
    Configuration menu
    Copy the full SHA
    a4d4102 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Merge branch 'main' into pac-guerreiro/refactor/39129-add-comments-to… 

    …-remaining-onyx-types
    @pac-guerreiro
    pac-guerreiro committed May 27, 2024
    Configuration menu
    Copy the full SHA
    8025926 View commit details
    Browse the repository at this point in the history

  2. docs: apply suggestions

    @pac-guerreiro
    pac-guerreiro committed May 27, 2024
    Configuration menu
    Copy the full SHA
    5599455 View commit details
    Browse the repository at this point in the history

  3. docs: apply suggestions

    @pac-guerreiro
    pac-guerreiro committed May 27, 2024
    Configuration menu
    Copy the full SHA
    2d91475 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Merge branch 'main' into pac-guerreiro/refactor/39129-add-comments-to… 

    …-remaining-onyx-types

# Conflicts:
#	src/types/onyx/Policy.ts
    @pac-guerreiro
    pac-guerreiro committed May 31, 2024
    Configuration menu
    Copy the full SHA
    da515a8 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2024

  1. Merge branch 'main' into pac-guerreiro/refactor/39129-add-comments-to… 

    …-remaining-onyx-types
    @pac-guerreiro
    pac-guerreiro committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    530b1ce View commit details
    Browse the repository at this point in the history

  2. refactor: apply pull request suggestions

    @pac-guerreiro
    pac-guerreiro committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    68ce115 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Merge branch 'main' into pac-guerreiro/refactor/39129-add-comments-to… 

    …-remaining-onyx-types

# Conflicts:
#	src/types/onyx/OriginalMessage.ts
#	src/types/onyx/Transaction.ts
    @pac-guerreiro
    pac-guerreiro committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    279e50a View commit details
    Browse the repository at this point in the history

  2. chore: apply pull request suggestions and address types with missing … 

    …comments
    @pac-guerreiro
    pac-guerreiro committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    9fe6712 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into pac-guerreiro/refactor/39129-add-comments-to… 

    …-remaining-onyx-types

# Conflicts:
#	src/pages/home/report/ReportFooter.tsx
    @pac-guerreiro
    pac-guerreiro committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    c46d709 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. chore: enable eslint rule that requires comments on onyx types and th… 

    …eir properties
    @pac-guerreiro
    pac-guerreiro committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    6dabcc0 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Merge branch 'main' into pac-guerreiro/refactor/39129-add-comments-to… 

    …-remaining-onyx-types

# Conflicts:
#	src/types/onyx/IOU.ts
    @pac-guerreiro
    pac-guerreiro committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    11090bd View commit details
    Browse the repository at this point in the history

  2. refactor: apply pull request suggestions

    @pac-guerreiro
    pac-guerreiro committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    453343e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into pac-guerreiro/refactor/39129-add-comments-to… 

    …-remaining-onyx-types
    @fabioh8010
    fabioh8010 committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    98fa483 View commit details
    Browse the repository at this point in the history

  4. Fix lint errors and improve comments

    @fabioh8010
    fabioh8010 committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    a354239 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into pac-guerreiro/refacto… 

    …r/39129-add-comments-to-remaining-onyx-types
    @fabioh8010
    fabioh8010 committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    199e228 View commit details
    Browse the repository at this point in the history