feat: add PromotedActionsBar

[kosmydel]

Details

This PR:

• Renames ChatDetailsQuickActionsBar.tsx to PromotedActionsBar.tsx and makes the PromotedActionsBar component generic and reusable.
• Changes the src/pages/ReportDetailsPage.tsx component so it uses the new component.
• Adds the newly created component to the Storybook.

Fixed Issues

$ #42071
PROPOSAL: N/A

Tests

1. Verify that no errors appear in the JS console
2. Verify that the usage of the component works as expected:
   1. Press FAB -> Start chat
   2. Select a few people
   3. Press the Header to open Details in RHP.
   4. Verify the Pin and Share promoted actions are displayed and work as expected.
   5. Verify the Leave button is a menu item and works as expected.
3. Verify the component in the Storybook: src/stories/PromotedActionBar.stories.tsx

Offline tests

N/A

QA Steps

• Verify that no errors appear in the JS console
• Do tests from the above (points 1-2).

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Old versions:

Android: mWeb Chrome

Old versions:

iOS: Native

iOS: mWeb Safari

Old versions:

MacOS: Chrome / Safari

Old versions:

web.mov

MacOS: Desktop

Old versions:

[cdOut]

LGTM!

[kosmydel]

Design changes: @Expensify/design

[kosmydel]

Adding a new screen with medium -sized buttons.

[melvin-bot]

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[shawnborton]

Can we use 8px as the gap between the buttons? I think we had this conversation previously when we were talking about the Search page buttons, and we seemed to like 8px as the standard gap. Does that sound familiar @Expensify/design? Or did we actually land on 12px?

[kosmydel]

Can we use 8px as the gap between the buttons? I think we had this conversation previously when we were talking about the Search page buttons, and we seemed to like 8px as the standard gap. Does that sound familiar @Expensify/design? Or did we actually land on 12px?

Sure, I can easily change it. Can you update the Figma designs first?

[shawnborton]

Let's see what the @Expensify/design thinks first.

[shawnborton]

Actually @kosmydel have you pulled main recently? I think what's happening is that these buttons might have an invisible wrapper that adds 1px of padding. So instead of 12px, your PR looks to have 14px gap between them:

We ran into this in a previous PR and I am pretty sure we just got rid of that 1px padding wrapper as it was pretty much pointless. Can you take a look at that first, and then we can evaluate from there?

[kosmydel]

I've updated this PR with a 50% maximum width for the actions bar, which was requested here.

Screenshots

[shawnborton]

I think there might have been a misunderstanding. We don't want a max width of 50% on the entire bar/container, but rather, we just want each individual button to have a max-width of 50%. So that this way, if there is only one button present, it only takes up 50% of the width and it should be centered.

[kosmydel]

I think there might have been a misunderstanding. We don't want a max width of 50% on the entire bar/container, but rather, we just want each individual button to have a max-width of 50%. So that this way, if there is only one button present, it only takes up 50% of the width and it should be centered.

Hmm, it is a screen from the Storybook. That's why it might appear strange. I'm attaching screenshots from RHP on the web.

Screenshots

Keep in mind that I've changed it programmatically, that's why we have duplicated Message actions.

[shawnborton]

Okay cool, that looks great to me - thanks for confirming!

[kosmydel]

I'm going to pull the latest main and test it :)

[grgia]

Do we have a WIP PR for this yet?

[kosmydel]

cc @cdOut

[cdOut]

I’m handling this one in my ReportDetailsPage PR, I’ll link it here after I put up a draft PR for it later in the evening.

[marcaaron]

Please check this PR we're already moving it there.

[grgia]

changes LGTM, only comment is about the TODOs, which we'd ideally want to omit

[kosmydel]

changes LGTM, only comment is about the TODOs, which we'd ideally want to omit

Alright :) I've removed the TODOs.

[rojiphil]

Rereviewing now

[grgia]

Code changes LGTM

[rojiphil]

Code LGTM. Also updated the checklist with latest test videos to ensure all is well.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/grgia in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/grgia in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.78-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅