-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Fix tax amount being displayed as negative #42039
Conversation
We shipped this regression with #40443. So we're CP'ing this PR |
I have been struggling with getting my VM and Auth working today. I will keep trying it so I can test this out, but if this is urgent, maybe we can find someone to test and merge this who already has a working environment. |
I got up and running and I'm testing this now |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Desktop |
FYI this PR didn't get CP'd by itself b/c the changes were included in this CP PR - https://github.com/Expensify/App/pull/42129/files |
🚀 Deployed to staging by https://github.com/tgolen in version: 1.4.74-0 🚀
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.74-6 🚀
|
Details
Mimics the same behaviour as in IOURequestStepAmount page
App/src/pages/iou/request/step/IOURequestStepAmount.tsx
Line 310 in 1184706
Fixed Issues
$ None
PROPOSAL:
Tests
Offline tests
Same as tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
See MacOS: Chrome / SafariAndroid: mWeb Chrome
See MacOS: Chrome / SafariiOS: Native
See MacOS: Chrome / SafariiOS: mWeb Safari
See MacOS: Chrome / SafariMacOS: Chrome / Safari
MacOS: Desktop
See MacOS: Chrome / Safari