Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bintray repository to speed up Android builds #4227

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

HorusGoul
Copy link
Contributor

@HorusGoul HorusGoul commented Jul 26, 2021

Details

I ran into long build times when developing some changes for the Android native part of the app (+30 minutes long builds!) and thought this made no sense.

I found out that the culprit was the Bintray repository, and removing it from the list of repositories is what solved the issue.

Why is the Bintray repository the cause? JFrog closed it!, and they wanted to close JCenter too. However, they say they'll keep that one as a read-only repository indefinitely.

I tried replacing jcenter with mavenCentral, but there are still some packages that we use and haven't migrated (for example, Flipper or some internal dependencies of react-native). We'll need to keep an eye on that in the future.

Tests/QA Steps

Run the following commands and make sure the app gets built in a reasonable amount of time:

cd android
./gradlew clean
cd ..
npx react-native run-android

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

N/A

@HorusGoul HorusGoul requested a review from a team July 26, 2021 16:58
@HorusGoul HorusGoul self-assigned this Jul 26, 2021
@MelvinBot MelvinBot requested review from Dal-Papa and removed request for a team July 26, 2021 16:58
@Dal-Papa Dal-Papa merged commit b2582f3 into main Jul 27, 2021
@Dal-Papa Dal-Papa deleted the horus-remove-bintray-repository-to-speed-up-builds branch July 27, 2021 07:22
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.80-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.81-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants