set error when click outside onboarding flow #42339

suneox · 2024-05-17T09:49:58Z

Details

Handle show error message when click outside of the onboarding purpose screen

Fixed Issues

$ #39965
PROPOSAL: #39965 (comment)

Tests

Sign up as a new user
Open route /onboarding/purpose (staging.expensify.com/onboarding/purpose)
Click outside the onboarding modal without selecting an option
Verify that the error message "Please press continue to get set up" is shown
Select any option
Click outside the onboarding modal
Verify that the error message "Please make a selection to continue" is shown

Verify that no errors appear in the JS console

Offline tests

QA Steps

Sign up as a new user
Open route /onboarding/purpose (staging.expensify.com/onboarding/purpose)
Click outside the onboarding modal without selecting an option
Verify that the error message "Please press continue to get set up" is shown
Select any option
Click outside the onboarding modal
Verify that the error message "Please make a selection to continue" is shown

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-17.at.16.34.08.mov

Android: mWeb Chrome

Screen.Recording.2024-05-17.at.16.27.44.mov

iOS: Native

Screen.Recording.2024-05-17.at.16.16.40.mov

iOS: mWeb Safari

Screen.Recording.2024-05-17.at.15.54.25.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-17.at.16.20.20.mov

MacOS: Desktop

Screen.Recording.2024-05-17.at.16.19.40.mov

melvin-bot · 2024-05-17T09:50:04Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2024-05-19T11:58:21Z

Screen.Recording.2024-05-19.at.5.27.00.PM.mov

@suneox Can you please add the similar logic too this page please?

suneox · 2024-05-19T15:27:56Z

Can you please add the similar logic too this page please?

@shubham1206agra I would like to confirm this is an extended scope? due to the expected result only show error message at onboarding purpose and on this PR is prevented validation on BaseOnboardingPersonalDetails screen, so is it conflict with PR #39687?

shubham1206agra · 2024-05-19T15:31:15Z

Oh
Thanks for letting me know
I will finish the review in the morning.

shubham1206agra · 2024-05-20T11:47:44Z

src/libs/Navigation/AppNavigator/Navigators/OnboardingModalNavigator.tsx

+    const handleKeyDown = useCallback((e: KeyboardEvent) => {
+        if (e.key !== CONST.KEYBOARD_SHORTCUTS.ESCAPE.shortcutKey) {
+            return;
+        }
+        OnboardingRefManager.handleOuterClick();
+    }, []);
+
+    useEffect(() => {
+        window?.addEventListener?.('keydown', handleKeyDown);
+        return () => {
+            window?.removeEventListener?.('keydown', handleKeyDown);
+        };
+    }, [handleKeyDown]);


Suggested change

const handleKeyDown = useCallback((e: KeyboardEvent) => {

if (e.key !== CONST.KEYBOARD_SHORTCUTS.ESCAPE.shortcutKey) {

return;

}

OnboardingRefManager.handleOuterClick();

}, []);

useEffect(() => {

window?.addEventListener?.('keydown', handleKeyDown);

return () => {

window?.removeEventListener?.('keydown', handleKeyDown);

};

}, [handleKeyDown]);

useKeyboardShortcut(CONST.KEYBOARD_SHORTCUTS.ESCAPE, handleOuterClick, {shouldBubble: true});

@suneox This is the shorter and cleaner version of the code.

shubham1206agra · 2024-05-20T12:10:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

NA

Android: mWeb Chrome

NA

iOS: Native

NA

iOS: mWeb Safari

NA

MacOS: Chrome / Safari

Screen.Recording.2024-05-20.at.5.24.57.PM.mov

MacOS: Desktop

Screen.Recording.2024-05-20.at.5.30.36.PM.mov

shubham1206agra · 2024-05-22T05:06:00Z

@mountiny Can you ask for translation confirmation please?

shubham1206agra · 2024-05-24T13:10:01Z

@mountiny Can we merge this now?

mountiny

@suneox Can you please confirm the translations per the classic process, thanks

src/languages/es.ts

…n-click-outside

mountiny

Thanks!

OSBotify · 2024-05-27T21:50:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-29T09:43:54Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T21:26:43Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-30T22:38:41Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

set error when click outside onboarding flow

7737f99

suneox requested a review from a team as a code owner May 17, 2024 09:49

melvin-bot bot requested review from shubham1206agra and removed request for a team May 17, 2024 09:50

suneox mentioned this pull request May 17, 2024

[HOLD for payment 2024-06-06] [$250] [Guided setup] No error messages when clicking outside the onboarding modal #39965

Closed

6 tasks

update translation

0c336ce

shubham1206agra reviewed May 20, 2024

View reviewed changes

mountiny assigned suneox May 20, 2024

suneox added 2 commits May 22, 2024 10:13

update keyboard shortcut

a11ddbf

fix eslint

0b1f443

shubham1206agra approved these changes May 22, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny May 22, 2024 05:05

mountiny changed the title ~~set error when click outside onboarding flow~~ [HOLD freeze] set error when click outside onboarding flow May 22, 2024

mountiny changed the title ~~[HOLD freeze] set error when click outside onboarding flow~~ set error when click outside onboarding flow May 24, 2024

mountiny reviewed May 24, 2024

View reviewed changes

src/languages/es.ts Show resolved Hide resolved

Merge remote-tracking branch 'upstream/main' into 39965-set-error-whe…

18367c1

…n-click-outside

mountiny approved these changes May 27, 2024

View reviewed changes

mountiny merged commit b720ae6 into Expensify:main May 27, 2024
15 checks passed

github-actions bot mentioned this pull request May 29, 2024

Deploy Checklist: New Expensify 2024-05-29 #42741

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

set error when click outside onboarding flow #42339

set error when click outside onboarding flow #42339

suneox commented May 17, 2024 •

edited

Loading

melvin-bot bot commented May 17, 2024

shubham1206agra commented May 19, 2024

suneox commented May 19, 2024 •

edited

Loading

shubham1206agra commented May 19, 2024

shubham1206agra May 20, 2024

shubham1206agra May 20, 2024

shubham1206agra commented May 20, 2024

shubham1206agra commented May 22, 2024

shubham1206agra commented May 24, 2024

mountiny left a comment

mountiny left a comment

OSBotify commented May 27, 2024

OSBotify commented May 29, 2024

OSBotify commented May 30, 2024

OSBotify commented May 30, 2024

set error when click outside onboarding flow #42339

set error when click outside onboarding flow #42339

Conversation

suneox commented May 17, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 17, 2024

shubham1206agra commented May 19, 2024

suneox commented May 19, 2024 • edited Loading

shubham1206agra commented May 19, 2024

shubham1206agra May 20, 2024

Choose a reason for hiding this comment

shubham1206agra May 20, 2024

Choose a reason for hiding this comment

shubham1206agra commented May 20, 2024

Reviewer Checklist

Screenshots/Videos

shubham1206agra commented May 22, 2024

shubham1206agra commented May 24, 2024

mountiny left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented May 27, 2024

OSBotify commented May 29, 2024

OSBotify commented May 30, 2024

OSBotify commented May 30, 2024

suneox commented May 17, 2024 •

edited

Loading

suneox commented May 19, 2024 •

edited

Loading