-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump markdown version to fix crash on reload #42343
fix: bump markdown version to fix crash on reload #42343
Conversation
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Since #42377 is not yet merged, I would merge it as patch for now if we want it merged ASAP. If no, I can change this PR to bumping to |
@WoLewicki I believe there was a new release created. Can you please update the pr? |
Ok so we want this PR to bump the |
Yes, that sounds good @mananjadhav could you list the changes in the markdown between the current version the one we are going to use here? Thanks! |
I was away Thu-Friday, I'll take a look at this tomorrow. |
@WoLewicki Did you say your changes are in |
@mananjadhav can you test if this is fixed on main then? |
@mountiny Sorry should've mentioned tested in one of the PR branches I worked. Anyway uploaded the video for Screen.Recording.2024-05-29.at.11.37.01.AM.mov |
Oh, so if it works correctly on main and the code is already there, then we can close this one 😄 |
Details
Fixed Issues
$ #42160
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-05-17.at.16.23.01.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop