fix User has to click twice to select currency #42380

tienifr · 2024-05-20T09:49:19Z

Details

Fixed Issues

$ #41922
PROPOSAL: #41922 (comment)

Tests

Open app.
Click on FAB > Submit expense > Click on the currency to open the currency selector.
Long press on a currency located around the bottom of the list.
The currency gets selected on the first click

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open app.
Click on FAB > Submit expense > Click on the currency to open the currency selector.
Long press on a currency located around the bottom of the list.
The currency gets selected on the first click

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-23.at.06.23.23.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-05-21.at.08.45.22.mov

iOS: mWeb Safari

Screen.Recording.2024-05-21.at.08.51.45.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-20.at.16.47.26.mov

MacOS: Desktop

Screen.Recording.2024-05-20.at.17.33.16.mov

melvin-bot · 2024-05-20T09:49:24Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jayeshmangwani · 2024-05-21T16:27:08Z

@tienifr Update the Test step And mention that we need to long press the currency, and also Android and Android chrome Videos are missing in the checklist

jayeshmangwani · 2024-05-21T16:43:12Z

@tienifr I am able to reproduce the original issue in Android chrome, would you confirm if its working for you.

jayeshmangwani · 2024-05-22T13:49:18Z

@tienifr bump for the update

tienifr · 2024-05-22T13:58:08Z

I am checking it

tienifr · 2024-05-22T23:44:03Z

@jayeshmangwani

I updated the test steps and added android native video.
Also, I confirm that the current solution does not fix the Android Chrome. In other pages where we use shouldPreventDefaultFocusOnSelectRow, the behavior is the same. I am investigating how to fix it in Android Chrome.

jayeshmangwani · 2024-05-23T06:04:37Z

Thanks for the update

jayeshmangwani · 2024-05-27T06:41:16Z

@tienifr Are you able to find the cause of why it's happening for Android Chrome?

tienifr · 2024-05-27T11:41:06Z

@jayeshmangwani I still investigate it.

tienifr · 2024-05-30T10:17:26Z

@jayeshmangwani My solution is, in here, add:

onLongPress={(e) => {
                    if (shouldPreventEnterKeySubmit && e && 'key' in e && e.key === CONST.KEYBOARD_SHORTCUTS.ENTER.shortcutKey) {
                        return;
                    }
                    onSelectRow(item);
                }}

so when the user long presses on any option, it will trigger onLongPress and do like we do with onPress. It can just apply this in Android Chrome. What do you think?

jayeshmangwani · 2024-05-30T16:15:35Z

so when the user long presses on any option, it will trigger onLongPress and do like we do with onPress. It can just apply this in Android Chrome. What do you think?

What's the reason why it's working for the mWeb safari and not the mWeb Chrome? It should be worked the same way in both Safari and Chrome

tienifr · 2024-05-31T11:09:31Z

I am still investigating the RCA.

jayeshmangwani · 2024-05-31T11:12:22Z

Thanks, I will also try to look into this today

tienifr · 2024-06-05T01:29:20Z

@jayeshmangwani Did you find the RCA?

jayeshmangwani · 2024-06-05T06:38:30Z

@tienifr No, But I am not confident in this solution either, I would suggest we should close this PR and open the original issue for the new proposals that also solve with the Android chrome too
cc: @Julesssss

tienifr · 2024-06-05T11:12:19Z

@jayeshmangwani @Julesssss

Currently, when we long press any button (for example, the "back" icon button) on Android web, the "onPress" event is not triggered. This behavior does not occur on iOS web (you can verify this by testing it). Hence, this seems to be a global issue affecting Android web rather than an isolated case.
An additional example can be observed on the chat-finder page or other similar pages, where the same issue occurs when we long-press on any option:

Screen.Recording.2024-06-05.at.17.59.50.mov

Therefore, I propose that we address this issue across all platforms as it is a straightforward fix. Subsequently, we can create a new issue specifically to resolve the long-press problem in Android Chrome.

Julesssss · 2024-06-05T12:35:52Z

Therefore, I propose that we address this issue across all platforms as it is a straightforward fix. Subsequently, we can create a new issue specifically to resolve the long-press problem in Android Chrome.

I mostly agree with this solution. Android mWeb seems like an outstanding issue that is related. Perhaps we could hold this temporarily to see if the solution to Android mWeb ends up giving us a similar solution here?

jayeshmangwani · 2024-06-05T12:49:55Z

Perhaps we could hold this temporarily to see if the solution to Android mWeb ends up giving us a similar solution here?

Are you suggesting that we should proceed with this PR and create a new issue for the Android Chrome's long-press problem?

Julesssss · 2024-06-05T13:40:44Z

Are you suggesting that we should proceed with this PR and create a new issue for the Android Chrome's long-press problem?

Yeah I see two options:

Finish this PR, isolated to mWeb
Hold this PR, wait for a proposal for the native permission (get approval for the library, etc)

I prefer the first, because it could take a while to prioritise and get a library solution implemented. Does that sound good?

jayeshmangwani · 2024-06-05T13:47:04Z

Yes, that sounds good. We will finish this PR and for Android chrome will open the other discussion

tienifr · 2024-06-06T10:37:30Z

@jayeshmangwani Should we continue to review it?

jayeshmangwani · 2024-06-06T10:39:47Z

Yes @tienifr , Will review in next 2 hours, I am on other PR rn and then review this

jayeshmangwani · 2024-06-06T11:36:17Z

App/src/components/SelectionList/InviteMemberListItem.tsx

Line 59 in 59a37c8