Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/41188 new messages button does not disappear #42406

Merged
merged 8 commits into from
May 27, 2024
Merged

Bugfix/41188 new messages button does not disappear #42406

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
49e097e
filtering out whispers when checking for newest report actions
burczu May 21, 2024
5e39755
prettier fixes
burczu May 21, 2024
d0bb2f5
comment added
burczu May 21, 2024
9b3e4d4
filtering out improved to just remove whispers from top
burczu May 22, 2024
ea78e1c
additional comment added
burczu May 22, 2024
1103fa0
switched to different approach with while instead of recurrence and s…
burczu May 22, 2024
14a3f22
unnecessary import removed
burczu May 22, 2024
6dfb6fd
code simplified
burczu May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/pages/home/report/ReportActionsList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,17 @@ function ReportActionsList({
),
[sortedReportActions, isOffline],
);

// whisper action doesn't affect lastVisibleActionCreated, so we should not take it into account while checking if there is newest report action
const newestVisibleReportAction = useMemo(() => {
const filteredReportActions = sortedVisibleReportActions.filter((reportAction) => !ReportActionsUtils.isWhisperAction(reportAction));

return filteredReportActions[0];
}, [sortedVisibleReportActions]);
burczu marked this conversation as resolved.
Show resolved Hide resolved

const lastActionIndex = sortedVisibleReportActions[0]?.reportActionID;
const reportActionSize = useRef(sortedVisibleReportActions.length);
const hasNewestReportAction = sortedVisibleReportActions?.[0]?.created === report.lastVisibleActionCreated;
const hasNewestReportAction = newestVisibleReportAction.created === report.lastVisibleActionCreated;
const hasNewestReportActionRef = useRef(hasNewestReportAction);
hasNewestReportActionRef.current = hasNewestReportAction;
const previousLastIndex = useRef(lastActionIndex);
Expand Down
Loading