Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/41188 new messages button does not disappear #42406

Merged
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/pages/home/report/ReportActionsList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import type {ListRenderItemInfo} from '@react-native/virtualized-lists/Lists/Vir
import {useIsFocused, useRoute} from '@react-navigation/native';
import type {RouteProp} from '@react-navigation/native';
import type {DebouncedFunc} from 'lodash';
import cloneDeep from 'lodash/cloneDeep';
import React, {memo, useCallback, useEffect, useMemo, useRef, useState} from 'react';
import {DeviceEventEmitter, InteractionManager} from 'react-native';
import type {LayoutChangeEvent, NativeScrollEvent, NativeSyntheticEvent, StyleProp, ViewStyle} from 'react-native';
Expand Down Expand Up @@ -209,9 +210,27 @@ function ReportActionsList({
),
[sortedReportActions, isOffline],
);

const filterOutLastWhisperAction = useCallback((actions: OnyxTypes.ReportAction[]): OnyxTypes.ReportAction[] => {
if (actions.length > 1 && ReportActionsUtils.isWhisperAction(actions[0])) {
actions.shift();
// repeat the process until the first action is not a whisper action
return filterOutLastWhisperAction(actions);
}

return actions;
}, []);

const newestVisibleReportAction = useMemo(() => {
// whisper action doesn't affect lastVisibleActionCreated, so we should not take it into account while checking if there is the newest report action
const filteredActions = filterOutLastWhisperAction(cloneDeep(sortedVisibleReportActions));

return filteredActions[0];
}, [filterOutLastWhisperAction, sortedVisibleReportActions]);
burczu marked this conversation as resolved.
Show resolved Hide resolved

const lastActionIndex = sortedVisibleReportActions[0]?.reportActionID;
const reportActionSize = useRef(sortedVisibleReportActions.length);
const hasNewestReportAction = sortedVisibleReportActions?.[0]?.created === report.lastVisibleActionCreated;
const hasNewestReportAction = newestVisibleReportAction.created === report.lastVisibleActionCreated;
const hasNewestReportActionRef = useRef(hasNewestReportAction);
hasNewestReportActionRef.current = hasNewestReportAction;
const previousLastIndex = useRef(lastActionIndex);
Expand Down
Loading