-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert add payment button changes #4242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment! Looking good otherwise
src/languages/es.js
Outdated
@@ -231,7 +231,8 @@ export default { | |||
enterYourUsernameToGetPaidViaPayPal: 'Escribe tu nombre de usuario para que otros puedan pagarte a través de PayPal.', | |||
payPalMe: 'PayPal.me/', | |||
yourPayPalUsername: 'Tu usuario de PayPal', | |||
addPayPalAccount: 'Agregar Cuenta de Paypal', | |||
addPayPalAccount: 'Agregar Cuenta de PayPal', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not capitalize Cuenta
here, since we don't capitalize usuario
above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Updated!
…PaymentButtonChanges
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging in version: 1.0.81-5🚀
|
🚀 Deployed to production in version: 1.0.82-7🚀
|
Details
We accidentally mislead a contributor to add some changes we don't actually want.
This PR:
Fixed Issues
$ #4238
Tests/QA
Tested On
Screenshots
Web
2021-07-26_18-15-58.mp4