Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert add payment button changes #4242

Merged
merged 7 commits into from
Jul 29, 2021
Merged

Conversation

stitesExpensify
Copy link
Contributor

@stitesExpensify stitesExpensify commented Jul 27, 2021

Details

We accidentally mislead a contributor to add some changes we don't actually want.

This PR:

  1. Removes the hiding of the "add payment method" button (you can always add accounts)
  2. Properly fixes a UI bug that would show multiple paypal accounts in your payment methods
  3. Navigates back to the payments page after you add a paypal account

Fixed Issues

$ #4238

Tests/QA

  1. Create a new account
  2. Go to the payments page in settings
  3. Click the "Add Payment Method" button
  4. Click the paypal.me button
  5. Enter a paypal.me username
  6. Make sure the button says "Add paypal account" and click it
  7. Make sure you are brought back to the payments page
  8. Make sure you see a new payment method
  9. Click the "Add Payment Method" button again
  10. Click the paypal.me button again
  11. Enter a different paypal.me username
  12. Make sure the button says "Update paypal account" and click it
  13. Make sure the paypal changes

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

2021-07-26_18-15-58.mp4

@stitesExpensify stitesExpensify self-assigned this Jul 27, 2021
@stitesExpensify stitesExpensify marked this pull request as ready for review July 27, 2021 18:03
@stitesExpensify stitesExpensify requested a review from a team as a code owner July 27, 2021 18:03
@MelvinBot MelvinBot requested review from Gonals and removed request for a team July 27, 2021 18:03
Copy link
Contributor

@Gonals Gonals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment! Looking good otherwise

@@ -231,7 +231,8 @@ export default {
enterYourUsernameToGetPaidViaPayPal: 'Escribe tu nombre de usuario para que otros puedan pagarte a través de PayPal.',
payPalMe: 'PayPal.me/',
yourPayPalUsername: 'Tu usuario de PayPal',
addPayPalAccount: 'Agregar Cuenta de Paypal',
addPayPalAccount: 'Agregar Cuenta de PayPal',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not capitalize Cuenta here, since we don't capitalize usuario above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Updated!

@Gonals Gonals merged commit f4ea025 into main Jul 29, 2021
@Gonals Gonals deleted the stites-revertAddPaymentButtonChanges branch July 29, 2021 07:47
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.81-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to production in version: 1.0.82-7🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants