-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QBO: Added explicit description for each export entity #42524
QBO: Added explicit description for each export entity #42524
Conversation
This is pretty much ready. Just need to add testing steps and update the Spanish translation |
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Need translation for the following:
|
Can we use these and then tag @pecanoro for review of the PR, thanks! :)
Vendor bill already on prod for reference:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The terms are really technical, so I am not sure if I chose the best translation for journal entry offset
1789123
to
256c717
Compare
256c717
to
f827cdb
Compare
Oops, totally my bad. Will raise a new PR with the correct base |
Here new one: #42548 |
Details
Fixed Issues
$ #42520
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
Networking issue
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop