Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QBO: Added explicit description for each export entity #42524

Closed

Conversation

s77rt
Copy link
Contributor

@s77rt s77rt commented May 23, 2024

Details

Fixed Issues

$ #42520
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native android
Android: mWeb Chrome

Networking issue

iOS: Native ios ios 2 ios 3 ios 4 ios 5 ios 6
iOS: mWeb Safari mweb-safari
MacOS: Chrome / Safari web
MacOS: Desktop desktop

@s77rt
Copy link
Contributor Author

s77rt commented May 23, 2024

This is pretty much ready. Just need to add testing steps and update the Spanish translation

@s77rt s77rt marked this pull request as ready for review May 23, 2024 14:20
@s77rt s77rt requested a review from a team as a code owner May 23, 2024 14:20
@melvin-bot melvin-bot bot requested review from shubham1206agra and removed request for a team May 23, 2024 14:20
Copy link

melvin-bot bot commented May 23, 2024

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@s77rt
Copy link
Contributor Author

s77rt commented May 23, 2024

cc @zanyrenney @trjExpensify

@s77rt s77rt changed the base branch from main to qbo-freeze-branch May 23, 2024 14:21
@s77rt s77rt changed the base branch from qbo-freeze-branch to main May 23, 2024 14:22
@s77rt
Copy link
Contributor Author

s77rt commented May 23, 2024

Need translation for the following:

  • This is your chosen account to post the journal entry offset for each report.
  • This is your chosen bank account to write checks from.
  • We'll create a single itemized check for each Expensify report. You can write the check from your bank account of choice (below).
  • We'll create a single itemized journal entry for each Expensify report. You can post the offset entry to your account of choice (below).

@trjExpensify
Copy link
Contributor

Can we use these and then tag @pecanoro for review of the PR, thanks! :)

  • This is your chosen account to post the journal entry offset for each report.

Esta es la cuenta elegida para contabilizar el asiento de compensación de cada informe.

  • This is your chosen bank account to write checks from.

Esta es la cuenta bancaria elegida para emitir cheques

  • We'll create a single itemized journal entry for each Expensify report. You can post the offset entry to your account of choice (below).

Crearemos un único asiento para cada informe de Expensify. Puedes contabilizar la contrapartida en la cuenta que elijas (a continuación).

  • We'll create a single itemized check for each Expensify report. You can write the check from your bank account of choice (below).

Crearemos un único cheque desglosado para cada informe de Expensify. Puedes emitir el cheque desde la cuenta bancaria que elijas (a continuación).


Vendor bill already on prod for reference:

  • We'll create a single itemized vendor bill for each Expensify report. If the period of the bill is closed, we'll post to the 1st of the next open period. You can add the vendor bill to your A/P account of choice (below).

Crearemos una única factura de proveedor detallada para cada informe de Expensify. Si el período de la factura está cerrado, lo publicaremos en el día 1 del siguiente período abierto. Puede agregar la factura del proveedor a la cuenta A/P de tu elección (a continuación).

Copy link
Contributor

@pecanoro pecanoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The terms are really technical, so I am not sure if I chose the best translation for journal entry offset

src/languages/es.ts Outdated Show resolved Hide resolved
src/languages/es.ts Outdated Show resolved Hide resolved
src/languages/es.ts Outdated Show resolved Hide resolved
src/languages/es.ts Outdated Show resolved Hide resolved
@s77rt s77rt force-pushed the qbo-out-of-pocket-expense-copy branch from 1789123 to 256c717 Compare May 23, 2024 17:46
@s77rt s77rt changed the base branch from main to qbo-freeze-branch May 23, 2024 17:47
@s77rt s77rt closed this May 23, 2024
@s77rt s77rt force-pushed the qbo-out-of-pocket-expense-copy branch from 256c717 to f827cdb Compare May 23, 2024 17:54
@s77rt
Copy link
Contributor Author

s77rt commented May 23, 2024

Oops, totally my bad. Will raise a new PR with the correct base

@s77rt s77rt deleted the qbo-out-of-pocket-expense-copy branch May 23, 2024 17:57
@s77rt
Copy link
Contributor Author

s77rt commented May 23, 2024

Here new one: #42548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants