Prevent accounts without account numbers from breaking the payments page #4262
Conversation
…rs, we can still render the item
There was a problem hiding this comment.
Any chance you (or @joekaufmanexpensify) can provide a screenshot ?
| @@ -83,12 +83,17 @@ class PaymentMethodList extends Component { | |||
| _.each(this.props.bankAccountList, (bankAccount) => { | |||
| // Add all bank accounts besides the wallet | |||
| if (bankAccount.type !== CONST.BANK_ACCOUNT_TYPES.WALLET) { | |||
| const formattedBankAccountNumber = bankAccount.accountNumber | |||
|
@Dal-Papa Are you looking for a screenshot of how my screen looks when I try to access the payments page from my test account? |
|
Ideally a screenshot of your screen with the fix that @stitesExpensify provided, but I think we can simply QA when that's out. |
|
Cool sounds good, feel free to ping me when it's time to QA! |
|
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging in version: 1.0.80-3🚀
|
|
@joekaufmanexpensify Can you go to your payments page and check if the app crashes? 😬 (following PR orders) |
|
I was able to access the Payments page from my expensifail account on staging!
|
|
🎉 Thanks @joekaufmanexpensify |
|
you're welcome! |
|
This issue can be checked off, but it looks like something weird is still going on though, we shouldn't be putting non-activated cards in the wallet since they can't be used. Would you mind making an issue for that @joekaufmanexpensify ? |
|
Wouldn't we want that listed there so the user can click the validate that card in the future? Even though I'm not using this card because it was sent by mistake, it's still a card that exists. Or is it just not expected behavior that the card is listed there right now because validating expensify cards in newdot doesn't exist yet? |
|
Yeah my thinking was that we would not show it for now since it is not usable, and then we'll start showing those again once we decide we want the ability to activate in newDot |
|
We are supposed to show the card in NewDot once it is activated though right? If that is what we do, then it could make sense to just add |
|
Well the cards are in different states. So basically the front end would only get activated cards from the server which means that when it is activated, it will automatically show up |
|
Ah got it, so we haven't really considered how the activation flow will work for Expensify Cards in NewDot at all? And we haven't even mapped out how we want un-activated cards to appear in NewDot yet for N6, so we should remove now and then add something like this when we've actively designed how this will work? |
|
Yep! That's what I'm thinking :) |
|
Sounds good. I'll make a new issue today! |
|
🚀 Deployed to production in version: 1.0.81-4🚀
|
Details
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/171546
Tests
QA Steps
Tested On