Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Transaction report shows multiline title for expense with multiline description #42631

Merged
merged 4 commits into from
Jun 4, 2024
Merged

fix: Transaction report shows multiline title for expense with multiline description #42631

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2cc73ac
fix: Transaction report shows multiline title for expense with multil…
nkdengineer May 27, 2024
61ec11b
Merge branch 'main' into fix/41584
nkdengineer May 30, 2024
652c8b2
use formatReportLastMessageText function
nkdengineer May 30, 2024
0490629
Merge branch 'main' into fix/41584
nkdengineer Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/ReportUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3153,7 +3153,7 @@ function getReportName(report: OnyxEntry<Report>, policy: OnyxEntry<Policy> = nu
if (isArchivedRoom(report)) {
formattedName += ` (${Localize.translateLocal('common.archived')})`;
}
return formattedName;
return formattedName.replace(/(\r\n|\n|\r)/gm, ' ');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App/src/libs/ReportUtils.ts

Line 3155 in e8ae3c5

return formattedName;

Should we apply the same fix in here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nkdengineer Could we use formatReportLastMessageText function instead of replacing manually?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we apply the same fix in here?

I think we can apply the same for this to prevent the same bug in the feature.

Could we use formatReportLastMessageText function instead of replacing manually?

Yes we can use this function.

}

if (parentReportAction?.message?.[0]?.isDeletedParentAction) {
Expand Down
Loading