Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Revert "[Travel] [Refactor] Create a new shared component for AddressPage" #42697

Merged
merged 1 commit into from
May 28, 2024
Merged

[CP Staging] Revert "[Travel] [Refactor] Create a new shared component for AddressPage" #42697

merged 1 commit into from
May 28, 2024

Conversation

mountiny
Copy link
Contributor

@mountiny mountiny commented May 28, 2024 •
edited
Loading

Reverts #41970

Straight revert

Fixes #42638

@mountiny mountiny self-assigned this May 28, 2024
@mountiny mountiny requested a review from a team as a code owner May 28, 2024 13:56
@mountiny mountiny changed the title Revert "[Travel] [Refactor] Create a new shared component for AddressPage" [CP Staging] Revert "[Travel] [Refactor] Create a new shared component for AddressPage" May 28, 2024
@melvin-bot melvin-bot bot removed the request for review from a team May 28, 2024 13:56
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 28, 2024

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested a review from youssef-lr May 28, 2024 13:56
@mountiny mountiny mentioned this pull request May 28, 2024
Closed
6 tasks
@mountiny
Copy link
Contributor Author

Straight revert, the checklist tests are failing but that is ok

@mountiny mountiny merged commit d137ce8 into main May 28, 2024
13 of 17 checks passed
@mountiny mountiny deleted the revert-41970-travel/address-page-refactor branch May 28, 2024 14:12
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented May 28, 2024

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label May 28, 2024
@mountiny
Copy link
Contributor Author

Noted above

OSBotify pushed a commit that referenced this pull request May 28, 2024
@mountiny @OSBotify
Merge pull request #42697 from Expensify/revert-41970-travel/address-…
42360c6 
…page-refactor

[CP Staging] Revert "[Travel] [Refactor] Create a new shared component for AddressPage"

(cherry picked from commit d137ce8)
@github-actions github-actions bot mentioned this pull request May 28, 2024
Closed
69 tasks
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 1.4.76-4 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.76-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puneetlath puneetlath puneetlath approved these changes

@youssef-lr youssef-lr Awaiting requested review from youssef-lr

Assignees

@mountiny mountiny

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mountiny @OSBotify @puneetlath