[CP Staging] Fix unable to add custom tag name in a new workspace #42734

nkdengineer · 2024-05-29T04:31:07Z

Details

Fix unable to add custom tag name in a new workspace

Fixed Issues

$ #42205
$ #42885
PROPOSAL: #42205 (comment)

Tests

Create a new workspace
Go to More feature and enable tag feature
Go to tag page and verify that setting option appears without creating any new tag
Click on setting and edit custom tag name
Verify that the custom tag name is edited

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Create a new workspace
Go to More feature and enable tag feature
Go to tag page and verify that setting option appears without creating any new tag
Click on setting and edit custom tag name
Verify that the custom tag name is edited

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-29.at.11.19.49.mov

Android: mWeb Chrome

Screen.Recording.2024-05-29.at.11.10.24.mov

iOS: Native

Screen.Recording.2024-05-29.at.11.17.59.mov

iOS: mWeb Safari

Screen.Recording.2024-05-29.at.11.13.01.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-29.at.11.04.55.mov

MacOS: Desktop

Screen.Recording.2024-05-29.at.11.21.50.mov

melvin-bot · 2024-05-29T04:31:35Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2024-05-29T04:33:59Z

ios/Podfile.lock

@@ -1852,7 +1852,7 @@ PODS:
  - RNGoogleSignin (10.0.1):
    - GoogleSignIn (~> 7.0)
    - React-Core
-  - RNLiveMarkdown (0.1.70):


why do we have the Podfile.lock changes in this one?

Missed to restore this change when running IOS.

Reverted this change.

mananjadhav · 2024-05-29T04:34:29Z

src/libs/actions/Policy/Policy.ts

@@ -3792,6 +3792,27 @@ function enablePolicyTags(policyID: string, enabled: boolean) {
            },
        ],
    };
+    const policyTagList = allPolicyTags?.[policyID];
+    if (!policyTagList) {


do we need an isEmpty check here?

I think we don't need policyTagList will never be an empty object.

mananjadhav · 2024-06-01T04:10:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-custom-tags.mov

Android: mWeb Chrome

mweb-chrome-custom-tags.mov

iOS: Native

ios-custom-tags.mov

iOS: mWeb Safari

mweb-safari-custom-tags.mov

MacOS: Chrome / Safari

web-custom-tags.mov

MacOS: Desktop

desktop-custom-tags.mov

nkdengineer · 2024-06-04T09:43:41Z

@cristipaval Please help to review the PR when you have a chance. Thanks.

OSBotify · 2024-06-04T11:51:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

mountiny · 2024-06-04T12:49:52Z

This should fix this deploy blocker so CPing #42885

Fix unable to add custom tag name in a new workspace (cherry picked from commit 92a7b15)

OSBotify · 2024-06-04T13:58:49Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.78-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Fix unable to add custom tag name in a new workspace

8b0d231

nkdengineer marked this pull request as ready for review May 29, 2024 04:31

nkdengineer requested a review from a team as a code owner May 29, 2024 04:31

melvin-bot bot requested review from mananjadhav and removed request for a team May 29, 2024 04:31

nkdengineer mentioned this pull request May 29, 2024

[HOLD for payment 2024-06-13] [HOLD for payment 2024-06-11] [$250] Tags settings – Unable to add Custom tag name in a new workspace #42205

Closed

6 tasks

mananjadhav reviewed May 29, 2024

View reviewed changes

nkdengineer added 3 commits May 29, 2024 11:42

revert unnecessary change

7cb364d

revert unnecessary change

b7a1a3b

merge main

96a41e2

mananjadhav approved these changes Jun 2, 2024

View reviewed changes

melvin-bot bot requested a review from cristipaval June 2, 2024 06:00

cristipaval approved these changes Jun 4, 2024

View reviewed changes

cristipaval merged commit 92a7b15 into Expensify:main Jun 4, 2024
16 checks passed

tienifr mentioned this pull request Jun 4, 2024

fix tag with undefined key is created in offline mode #43018

Closed

50 tasks

mountiny assigned nkdengineer Jun 4, 2024

mountiny changed the title ~~Fix unable to add custom tag name in a new workspace~~ [CP Staging] Fix unable to add custom tag name in a new workspace Jun 4, 2024

OSBotify pushed a commit that referenced this pull request Jun 4, 2024

Merge pull request #42734 from nkdengineer/fix/42205

bdb5533

Fix unable to add custom tag name in a new workspace (cherry picked from commit 92a7b15)

github-actions bot mentioned this pull request Jun 4, 2024

Deploy Checklist: New Expensify 2024-05-30 #42872

Closed

95 tasks

melvin-bot bot mentioned this pull request Jun 4, 2024

[HOLD for payment 2024-06-13] [HOLD for payment 2024-06-11] [$250] Tags - Console error when disabling tag when created offline on web, app crashes on iOS #42885

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Fix unable to add custom tag name in a new workspace #42734

[CP Staging] Fix unable to add custom tag name in a new workspace #42734

nkdengineer commented May 29, 2024 •

edited by mountiny

Loading

melvin-bot bot commented May 29, 2024

mananjadhav May 29, 2024

nkdengineer May 29, 2024

nkdengineer May 29, 2024

mananjadhav May 29, 2024

nkdengineer May 29, 2024

mananjadhav commented Jun 1, 2024 •

edited

Loading

nkdengineer commented Jun 4, 2024

OSBotify commented Jun 4, 2024

mountiny commented Jun 4, 2024

OSBotify commented Jun 4, 2024

[CP Staging] Fix unable to add custom tag name in a new workspace #42734

[CP Staging] Fix unable to add custom tag name in a new workspace #42734

Conversation

nkdengineer commented May 29, 2024 • edited by mountiny Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 29, 2024

mananjadhav May 29, 2024

Choose a reason for hiding this comment

nkdengineer May 29, 2024

Choose a reason for hiding this comment

nkdengineer May 29, 2024

Choose a reason for hiding this comment

mananjadhav May 29, 2024

Choose a reason for hiding this comment

nkdengineer May 29, 2024

Choose a reason for hiding this comment

mananjadhav commented Jun 1, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

nkdengineer commented Jun 4, 2024

OSBotify commented Jun 4, 2024

mountiny commented Jun 4, 2024

OSBotify commented Jun 4, 2024

nkdengineer commented May 29, 2024 •

edited by mountiny

Loading

mananjadhav commented Jun 1, 2024 •

edited

Loading