Enable `no-unsafe-call` eslint rule #42743

bgawkuc · 2024-05-29T09:50:39Z

Details

Fixed Issues

$ #39119
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console
Build that app and check that it doesn't crash
Test the main flows of the app (sending messages, requesting money, login)

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android-native.mov

Android: mWeb Chrome

android-Chrome.mov

iOS: Native

ios-native.mov

iOS: mWeb Safari

ios-Safari.mov

MacOS: Chrome / Safari

MacOS-Chrome.mov

MacOS: Desktop

MacOS-desktop.mov

…sify-app-fork into ts/enable-no-unsafe-call

melvin-bot · 2024-05-29T09:50:44Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

github-actions · 2024-05-29T09:50:52Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

bgawkuc · 2024-05-29T10:16:09Z

I have read the CLA Document and I hereby sign the CLA

blazejkustra

Great work, added couple comments

tests/unit/postTestBuildComment.ts

src/pages/iou/MoneyRequestAmountForm.tsx

src/libs/StartupTimer/index.native.ts

src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx

src/libs/Environment/betaChecker/index.ios.ts

src/components/Tooltip/PopoverAnchorTooltip.tsx

src/components/TextInput/BaseTextInput/isAnimatedTextInputFocused.ts

blazejkustra

Ops, sorry I meant "Request changes" 😅

…sify-app-fork into ts/enable-no-unsafe-call

blazejkustra

LGTM!

.github/actions/javascript/getGraphiteString/getGraphiteString.ts

.storybook/webpack.config.ts

config/webpack/webpack.common.ts

src/components/MoneyRequestAmountInput.tsx

src/components/TextInput/BaseTextInput/isAnimatedTextInputFocused.ts

src/components/WalletStatementModal/index.tsx

melvin-bot · 2024-06-05T15:15:04Z

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

blazejkustra · 2024-06-06T07:19:37Z

@bgawkuc Lint is failing, try merging the newest main first 👍

blazejkustra · 2024-06-06T07:24:59Z

@carlosmiceli This PR is a part of this issue, I think @parasharrajat should be added as reviewing C+.

parasharrajat · 2024-06-06T08:04:49Z

Ah, Looks like the issue was not linked in the correct format.

bgawkuc · 2024-06-07T10:04:20Z

Hi @parasharrajat, this PR is ready for review 😄

desktop/main.ts

src/components/TextInput/BaseTextInput/isAnimatedTextInputFocused.ts

src/components/Hoverable/ActiveHoverable.tsx

src/components/MoneyRequestAmountInput.tsx

src/libs/Performance.tsx

src/libs/updateMultilineInputRange/index.ts

bgawkuc · 2024-06-10T12:11:39Z

@parasharrajat I've made all the necessary changes. Please check it again

parasharrajat · 2024-06-10T17:19:59Z

@bgawkuc Please merge main.

…sify-app-fork into ts/enable-no-unsafe-call

bgawkuc · 2024-06-11T08:37:18Z

@parasharrajat Done!

parasharrajat · 2024-06-11T10:29:21Z

Screenshots

🔲 iOS / native

11.06.2024_15.57.14_REC.mp4

🔲 iOS / Safari

11.06.2024_15.54.53_REC.mp4

🔲 MacOS / Desktop

11.06.2024_15.58.17_REC.mp4

🔲 MacOS / Chrome

11.06.2024_15.52.08_REC.mp4

🔲 Android / Chrome

11.06.2024_18.12.37_REC.mp4

🔲 Android / native

11.06.2024_17.53.48_REC.mp4

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

carlosmiceli

LGTM but I'd like @mountiny's input here too.

mountiny

Just one comment

mountiny · 2024-06-12T09:44:01Z

src/components/TextInput/BaseTextInput/isTextInputFocused.ts

+import type {AnimatedTextInputRef} from '@components/RNTextInput';
+import type {BaseTextInputRef} from './types';
+
+/** Checks that text input has the isFocused method and is focused. */
+export default function isTextInputFocused(textInput: React.MutableRefObject<BaseTextInputRef | null>): boolean | null {
+    return textInput.current && 'isFocused' in textInput.current && (textInput.current as AnimatedTextInputRef).isFocused();
+}


This feels more like some utility function, is this indeed the best place to put such method based on our guidelines?

This is the main/core text input so nab, moving this ahead

OSBotify · 2024-06-12T10:12:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-14T23:03:04Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.83-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

bgawkuc added 11 commits May 22, 2024 15:11

enable no-unsafe-call rule

8f019fd

fix all text input ref errors

df002bc

wip

03e4302

move isAnimatedTextInputRef function to common file

6cd6194

simplify changes

ae1804a

Merge branch 'main' of https://github.com/software-mansion-labs/expen…

b82c7ed

…sify-app-fork into ts/enable-no-unsafe-call

wip

48de655

rename text input function & change performance types

238abd6

wip

9fc260d

wip

6ae0cca

fix tests errors

2cbb545

blazejkustra approved these changes Jun 4, 2024

View reviewed changes

blazejkustra reviewed Jun 4, 2024

View reviewed changes

bgawkuc added 5 commits June 4, 2024 14:31

define types for NativeModules

8bdd994

add JSDoc to isAnimatedTextInputFocused

2b2ab09

fix webpack plugin props

55a69fd

Merge branch 'main' of https://github.com/software-mansion-labs/expen…

2a983c9

…sify-app-fork into ts/enable-no-unsafe-call

fix ts error

0723e43

blazejkustra approved these changes Jun 5, 2024

View reviewed changes

fabioh8010 reviewed Jun 5, 2024

View reviewed changes

bgawkuc added 3 commits June 5, 2024 14:39

review adjustments

42f1f6d

fix storybook

75b085a

rename preload webpack plugin type

729aaa1

fabioh8010 approved these changes Jun 5, 2024

View reviewed changes

bgawkuc marked this pull request as ready for review June 5, 2024 15:14

bgawkuc requested a review from a team as a code owner June 5, 2024 15:14

melvin-bot bot removed the request for review from a team June 5, 2024 15:15

blazejkustra mentioned this pull request Jun 6, 2024

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [HOLD for payment 2024-07-10] [$500] [TS Migration] Adjust eslint config, TS config #39119

Closed

add create download queue types

fbaa95f

change parse run opts

355deae

parasharrajat suggested changes Jun 8, 2024

View reviewed changes

bgawkuc added 4 commits June 10, 2024 10:58

rename text input focused function and mouse event type

7d8dbc4

move CreateDownloadQueue type

4541ce2

remove redundant check

cbe212e

add module declaration for react-native-performance

90552a4

Merge branch 'main' of https://github.com/software-mansion-labs/expen…

a702e5f

…sify-app-fork into ts/enable-no-unsafe-call

blazejkustra approved these changes Jun 11, 2024

View reviewed changes

bgawkuc requested a review from parasharrajat June 11, 2024 09:08

parasharrajat approved these changes Jun 11, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny June 11, 2024 12:44

carlosmiceli approved these changes Jun 11, 2024

View reviewed changes

Merge branch 'main' into ts/enable-no-unsafe-call

649529e

mountiny assigned bgawkuc Jun 12, 2024

mountiny approved these changes Jun 12, 2024

View reviewed changes

mountiny merged commit 3523ca6 into Expensify:main Jun 12, 2024
18 checks passed

github-actions bot mentioned this pull request Jun 13, 2024

Deploy Checklist: New Expensify 2024-06-13 #43655

Closed

64 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable `no-unsafe-call` eslint rule #42743

Enable `no-unsafe-call` eslint rule #42743

bgawkuc commented May 29, 2024 •

edited

Loading

melvin-bot bot commented May 29, 2024

github-actions bot commented May 29, 2024 •

edited

Loading

bgawkuc commented May 29, 2024

blazejkustra left a comment

blazejkustra left a comment

blazejkustra left a comment

melvin-bot bot commented Jun 5, 2024

blazejkustra commented Jun 6, 2024

blazejkustra commented Jun 6, 2024

parasharrajat commented Jun 6, 2024

bgawkuc commented Jun 7, 2024

bgawkuc commented Jun 10, 2024 •

edited

Loading

parasharrajat commented Jun 10, 2024

bgawkuc commented Jun 11, 2024

parasharrajat commented Jun 11, 2024 •

edited

Loading

parasharrajat left a comment

carlosmiceli left a comment

mountiny left a comment

mountiny Jun 12, 2024

mountiny Jun 12, 2024

OSBotify commented Jun 12, 2024

OSBotify commented Jun 14, 2024

Enable no-unsafe-call eslint rule #42743

Enable no-unsafe-call eslint rule #42743

Conversation

bgawkuc commented May 29, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 29, 2024

github-actions bot commented May 29, 2024 • edited Loading

bgawkuc commented May 29, 2024

blazejkustra left a comment

Choose a reason for hiding this comment

blazejkustra left a comment

Choose a reason for hiding this comment

blazejkustra left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jun 5, 2024

blazejkustra commented Jun 6, 2024

blazejkustra commented Jun 6, 2024

parasharrajat commented Jun 6, 2024

bgawkuc commented Jun 7, 2024

bgawkuc commented Jun 10, 2024 • edited Loading

parasharrajat commented Jun 10, 2024

bgawkuc commented Jun 11, 2024

parasharrajat commented Jun 11, 2024 • edited Loading

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

carlosmiceli left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

mountiny Jun 12, 2024

Choose a reason for hiding this comment

mountiny Jun 12, 2024

Choose a reason for hiding this comment

OSBotify commented Jun 12, 2024

OSBotify commented Jun 14, 2024

Enable `no-unsafe-call` eslint rule #42743

Enable `no-unsafe-call` eslint rule #42743

bgawkuc commented May 29, 2024 •

edited

Loading

github-actions bot commented May 29, 2024 •

edited

Loading

bgawkuc commented Jun 10, 2024 •

edited

Loading

parasharrajat commented Jun 11, 2024 •

edited

Loading