show onboarding modal for RHP signin from public rooms for new accounts #42820

c3024 · 2024-05-30T08:35:40Z

Details

Fixed Issues

$ #41500
PROPOSAL: #41500 (comment)

Tests

Logout of ND if logged in
Visit any public room
Press Sign In button on the bottom right
Sign In from the Right Hand Panel with a new account
Verify that the Onboarding Modal appears after sign in is complete

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

rhpOnboardingAndroid.mp4

Android: mWeb Chrome

rhpOnboardingAndroidmWeb.mp4

iOS: Native

rhpOnboardingiOS.mp4

iOS: mWeb Safari

rhpOnboardingiOSmWeb.mp4

MacOS: Chrome / Safari

rhpOnboard.mp4

MacOS: Desktop

NA

There is no support for deeplink for anonymous users on Desktop

App/src/libs/actions/App.ts

Lines 509 to 513 in d6faf52

    
           function beginDeepLinkRedirect(shouldAuthenticateWithCurrentAccount = true) { 
        
               // There's no support for anonymous users on desktop 
        
               if (Session.isAnonymousUser()) { 
        
                   return; 
        
               }

App/src/components/DeeplinkWrapper/index.website.tsx

Lines 66 to 75 in d6faf52

    
           if ( 
        
               !isMacOSWeb() || 
        
               isUnsupportedDeeplinkRoute || 
        
               hasShownPrompt || 
        
               CONFIG.ENVIRONMENT === CONST.ENVIRONMENT.DEV || 
        
               autoAuthState === CONST.AUTO_AUTH_STATE.NOT_STARTED || 
        
               Session.isAnonymousUser() 
        
           ) { 
        
               return; 
        
           }

melvin-bot · 2024-05-30T08:35:45Z

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

c3024 · 2024-06-01T12:35:43Z

Bump @rojiphil for review please

rojiphil · 2024-06-03T11:23:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari

42820-web-safari-001.mp4

Android: Native

42820-android-native-001.mp4

Android: mWeb Chrome

42820-mweb-chrome-001.mp4

iOS: Native

42820-ios-native-001.mp4

iOS: mWeb Safari

42820-mweb-safari-001.mp4

MacOS: Desktop

NA

rojiphil

LGTM. Tests well too and completed checklist

OSBotify · 2024-06-12T14:18:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

kavimuru · 2024-06-13T19:55:22Z

This PR is failing with existing bug #41500 which is not fixed.
Reproduced in android iOS web and mweb

https://platform.utest.com/services/links/v1/internal/51740692?.mp4
https://platform.utest.com/services/links/v1/internal/51740874?.mp4
https://platform.utest.com/services/links/v1/internal/51740873?.mp4
https://platform.utest.com/services/links/v1/internal/51744148?.mp4

c3024 · 2024-06-14T06:05:54Z

I cannot access these links. Can you share the videos here? It might be failing due to backend response.

kavimuru · 2024-06-14T18:31:59Z

videos are here

1718296011315.Video_de_WhatsApp_2024-06-13_a_las_11.26.08_4ab02f00.mp4

1718286533221.Recording__3189.mp4

1718286533210.Recording__3190.mp4

1718286014912.Recording__3188.mp4

OSBotify · 2024-06-14T23:03:13Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.83-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rojiphil · 2024-06-15T06:20:32Z

videos are here

@kavimuru Thanks for the videos.
I could also reproduce the issue.
Looks like some recent changes have caused this.

c3024 · 2024-06-16T11:08:26Z

I found that OpenApp now sends onboarding as [] when opening public rooms anonymously

and this here

App/src/libs/actions/Welcome.ts

Line 33 in 75c104b

    
           if (Array.isArray(onboarding) || onboarding?.hasCompletedGuidedSetupFlow === undefined) {

returns early.

Backend should send [] only for accounts created on old dot and old accounts.

So, I think this first needs a fix on backend.

cc: @rojiphil @grgia @mountiny

rojiphil · 2024-06-17T20:08:14Z

I found that OpenApp now sends onboarding as [] when opening public rooms anonymously

and this here

App/src/libs/actions/Welcome.ts

Line 33 in 75c104b

if (Array.isArray(onboarding) || onboarding?.hasCompletedGuidedSetupFlow === undefined) {

returns early.

Thanks @c3024. I just checked and agree with the analysis.
For a new login, I think it makes sense for BE to send hasCompletedGuidedSetupFlow as false in openApp. This would solve the problem.
But then we will wait for @grgia to weigh in here.

mountiny · 2024-06-20T22:22:04Z

@c3024 @rojiphil can you please bring this up to slack and tag me?

rojiphil · 2024-06-24T08:41:26Z

can you please bring this up to slack and tag me?

Brought this to slack here

show onboarding modal from RHP signin

70b3dc2

c3024 requested a review from a team as a code owner May 30, 2024 08:35

melvin-bot bot requested review from rojiphil and removed request for a team May 30, 2024 08:35

rojiphil approved these changes Jun 3, 2024

View reviewed changes

melvin-bot bot requested a review from grgia June 3, 2024 11:33

grgia approved these changes Jun 12, 2024

View reviewed changes

grgia merged commit 100df70 into Expensify:main Jun 12, 2024
18 checks passed

github-actions bot mentioned this pull request Jun 13, 2024

Deploy Checklist: New Expensify 2024-06-13 #43655

Closed

64 tasks

mountiny mentioned this pull request Jun 14, 2024

[$250] Log in – Welcome modal is missing when login as a new user from public room login modal #41500

Closed

c3024 mentioned this pull request Aug 5, 2024

[HOLD for #415000] [$250] Room - Endless skeleton loader when a new account logs in after navigating to a public room #46105

Open

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

show onboarding modal for RHP signin from public rooms for new accounts #42820

show onboarding modal for RHP signin from public rooms for new accounts #42820

c3024 commented May 30, 2024 •

edited

Loading

melvin-bot bot commented May 30, 2024

c3024 commented Jun 1, 2024

rojiphil commented Jun 3, 2024

rojiphil left a comment

OSBotify commented Jun 12, 2024

kavimuru commented Jun 13, 2024

c3024 commented Jun 14, 2024

kavimuru commented Jun 14, 2024

OSBotify commented Jun 14, 2024

rojiphil commented Jun 15, 2024

c3024 commented Jun 16, 2024 •

edited

Loading

rojiphil commented Jun 17, 2024

mountiny commented Jun 20, 2024

rojiphil commented Jun 24, 2024

	function beginDeepLinkRedirect(shouldAuthenticateWithCurrentAccount = true) {
	// There's no support for anonymous users on desktop
	if (Session.isAnonymousUser()) {
	return;
	}

	if (
	!isMacOSWeb() \|\|
	isUnsupportedDeeplinkRoute \|\|
	hasShownPrompt \|\|
	CONFIG.ENVIRONMENT === CONST.ENVIRONMENT.DEV \|\|
	autoAuthState === CONST.AUTO_AUTH_STATE.NOT_STARTED \|\|
	Session.isAnonymousUser()
	) {
	return;
	}

show onboarding modal for RHP signin from public rooms for new accounts #42820

show onboarding modal for RHP signin from public rooms for new accounts #42820

Conversation

c3024 commented May 30, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 30, 2024

c3024 commented Jun 1, 2024

rojiphil commented Jun 3, 2024

Reviewer Checklist

Screenshots/Videos

rojiphil left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 12, 2024

kavimuru commented Jun 13, 2024

c3024 commented Jun 14, 2024

kavimuru commented Jun 14, 2024

OSBotify commented Jun 14, 2024

rojiphil commented Jun 15, 2024

c3024 commented Jun 16, 2024 • edited Loading

rojiphil commented Jun 17, 2024

mountiny commented Jun 20, 2024

rojiphil commented Jun 24, 2024

c3024 commented May 30, 2024 •

edited

Loading

c3024 commented Jun 16, 2024 •

edited

Loading