Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: Taxes - App allows deleted tax rate to be selected as currency default in offline mode." #42953

Closed
wants to merge 1 commit into from

Conversation

iwiznia
Copy link
Contributor

@iwiznia iwiznia commented May 31, 2024

@iwiznia iwiznia self-assigned this May 31, 2024
@iwiznia iwiznia requested a review from a team as a code owner May 31, 2024 21:58
@melvin-bot melvin-bot bot requested review from youssef-lr and removed request for a team May 31, 2024 21:59
Copy link

melvin-bot bot commented May 31, 2024

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Krishna2323
Copy link
Contributor

Krishna2323 commented May 31, 2024

@iwiznia, do we need a revert? I was waiting for response on #42620 (comment).

@iwiznia
Copy link
Contributor Author

iwiznia commented May 31, 2024

We don't need it but seems like the simplest option. You can work on re-sending the PR with the needed changes without us having to decide between blocking a deploy or deploying "broken" code or having to do a CP to staging.
As for the answer, I think you'll find it in the issue that was open due to it.

@iwiznia
Copy link
Contributor Author

iwiznia commented May 31, 2024

Oh wait, I guess we will have to CP the code either way (or deploy the broken code). Anyway, we can close this revert if the PR you send is ready to go in the next deploy.

@Krishna2323
Copy link
Contributor

@iwiznia, ok, can you pls confirm this #42620 (comment) for me? After that I will raise the PR within an hour or two.

@iwiznia
Copy link
Contributor Author

iwiznia commented May 31, 2024

k, can you pls confirm this #42620 (comment) for me?

I think you'll find the answer to it in the issue that was open here #42918

@MonilBhavsar
Copy link
Contributor

Followup PR #42974 is made, so I think we can close this. Thanks @Krishna2323!

@youssef-lr
Copy link
Contributor

Can we close this?

@youssef-lr
Copy link
Contributor

I think we can close 😀

@youssef-lr youssef-lr closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants