Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of missing translation #42970

Merged
merged 37 commits into from
Jun 17, 2024
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
7dae918
get rid of missing translation FormHelpMessage
nkdengineer Jun 2, 2024
7010adf
Fix translate error for DotIndicatorMessage
nkdengineer Jun 3, 2024
7d39bf5
fix test
nkdengineer Jun 3, 2024
6177f8b
fix error utils test
nkdengineer Jun 3, 2024
0451213
complete fix tes
nkdengineer Jun 3, 2024
7b70d73
fix translation error
nkdengineer Jun 3, 2024
55a9077
remove the use of MaybePhraseKey type
nkdengineer Jun 3, 2024
4320a8c
merge main
nkdengineer Jun 3, 2024
20e829f
fix test
nkdengineer Jun 3, 2024
a7fb548
fix lint
nkdengineer Jun 3, 2024
6d3a233
fix test
nkdengineer Jun 3, 2024
0c4cabc
fix prettier
nkdengineer Jun 3, 2024
f29281c
add missing form helper error translation
nkdengineer Jun 3, 2024
74f3f1d
merge main
nkdengineer Jun 4, 2024
5fb3199
merge main
nkdengineer Jun 4, 2024
ba60fea
clean code
nkdengineer Jun 4, 2024
97910d1
merge main
nkdengineer Jun 6, 2024
6f6b5aa
Update src/components/MoneyRequestConfirmationList.tsx
nkdengineer Jun 6, 2024
c8bb635
Update src/components/AddressForm.tsx
nkdengineer Jun 6, 2024
0416297
remove func translateIfPhraseKey and clean code
nkdengineer Jun 6, 2024
727b30a
fix lint
nkdengineer Jun 6, 2024
1383ae8
resolve conflict
nkdengineer Jun 7, 2024
927288f
fix typecheck
nkdengineer Jun 7, 2024
8190fa3
merge main
nkdengineer Jun 10, 2024
506ac9a
fix ts error
nkdengineer Jun 10, 2024
15e9eba
fix lint
nkdengineer Jun 10, 2024
6968d60
Merge branch 'main' into fix/42539
nkdengineer Jun 11, 2024
4edb5ed
merge main
nkdengineer Jun 12, 2024
d90a9df
fix: add missing translation
nkdengineer Jun 12, 2024
c4dd3da
merge main
nkdengineer Jun 13, 2024
174d975
fix type
nkdengineer Jun 13, 2024
bfb9464
merge main
nkdengineer Jun 13, 2024
b6b85d2
fix lint
nkdengineer Jun 13, 2024
61255a3
merge main
nkdengineer Jun 13, 2024
7603cb4
remove type MaybePhraseKey
nkdengineer Jun 14, 2024
899dc4e
merge main
nkdengineer Jun 17, 2024
1ef917b
Merge branch 'main' into fix/42539
francoisl Jun 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
merge main
  • Loading branch information
nkdengineer committed Jun 4, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 74f3f1de39c9185369c8d0f72adf60b15cf5bd5b
4 changes: 2 additions & 2 deletions src/libs/OptionsListUtils.ts
Original file line number Diff line number Diff line change
@@ -538,8 +538,8 @@ function getAllReportErrors(report: OnyxEntry<Report>, reportActions: OnyxEntry<
reportActionErrors.smartscan = ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('iou.error.genericSmartscanFailureMessage');
}
} else if ((ReportUtils.isIOUReport(report) || ReportUtils.isExpenseReport(report)) && report?.ownerAccountID === currentUserAccountID) {
if (ReportUtils.hasMissingSmartscanFields(report?.reportID ?? '') && !ReportUtils.isSettled(report?.reportID)) {
reportActionErrors.smartscan = ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('iou.error.genericSmartscanFailureMessage');
if (ReportUtils.shouldShowRBRForMissingSmartscanFields(report?.reportID ?? '') && !ReportUtils.isSettled(report?.reportID)) {
reportActionErrors.smartscan = ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('report.genericSmartscanFailureMessage');
}
} else if (ReportUtils.hasSmartscanError(Object.values(reportActions ?? {}))) {
reportActionErrors.smartscan = ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('iou.error.genericSmartscanFailureMessage');
2 changes: 1 addition & 1 deletion src/pages/iou/MoneyRequestAmountForm.tsx
Original file line number Diff line number Diff line change
@@ -223,7 +223,7 @@ function MoneyRequestAmountForm(

onSubmitButtonPress({amount: currentAmount, currency, paymentMethod: iouPaymentType});
},
[taxAmount, initializeAmount, onSubmitButtonPress, currency, translate, formattedTaxAmount],
[taxAmount, onSubmitButtonPress, currency, translate, formattedTaxAmount],
);

const buttonText: string = useMemo(() => {
You are viewing a condensed version of this merge commit. You can view the full changes here.