Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a switch for requiring tags on the multi level tags RHP #42972

Merged
merged 45 commits into from
Jun 13, 2024
Merged

Add a switch for requiring tags on the multi level tags RHP #42972

merged 45 commits into from
Jun 13, 2024

Commits on Jun 2, 2024

  1. feat: pass a new parameter to the requires tags api

    Hayata Suenaga committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    59c508b View commit details
    Browse the repository at this point in the history

  2. chore: add new constant

    Hayata Suenaga committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    6a2c8ee View commit details
    Browse the repository at this point in the history

  3. feat: add the toggle button

    Hayata Suenaga committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    336c036 View commit details
    Browse the repository at this point in the history

  4. chore: disable the switch if all tags are not active

    Hayata Suenaga committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    5bcd53b View commit details
    Browse the repository at this point in the history

  5. fix: remove unnecessary import

    Hayata Suenaga committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    95c360b View commit details
    Browse the repository at this point in the history

  6. fix: UI copy and error message

    Hayata Suenaga committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    75b21eb View commit details
    Browse the repository at this point in the history

  7. fix: component position

    Hayata Suenaga committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    39f7fac View commit details
    Browse the repository at this point in the history

  8. chore: remove unused error util

    Hayata Suenaga committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    6a03be3 View commit details
    Browse the repository at this point in the history

  9. fix: swap the API to call

    Hayata Suenaga committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    e1246a8 View commit details
    Browse the repository at this point in the history

  10. fix: add back the command to make all tags required

    Hayata Suenaga committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    da8ca41 View commit details
    Browse the repository at this point in the history

  11. chore: add back the API param type

    Hayata Suenaga committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    ec97f63 View commit details
    Browse the repository at this point in the history

  12. chore: add back the API command

    Hayata Suenaga committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    18e3d27 View commit details
    Browse the repository at this point in the history

  13. chore: export the parameter type

    Hayata Suenaga committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    ffd3507 View commit details
    Browse the repository at this point in the history

  14. fix: add back the old API call

    Hayata Suenaga committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    21c49fe View commit details
    Browse the repository at this point in the history

  15. fix: remove extra parameters

    Hayata Suenaga committed Jun 2, 2024
    Configuration menu
    Copy the full SHA
    b477d14 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. fix: remove null

    Hayata Suenaga committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    3a450df View commit details
    Browse the repository at this point in the history

  2. fix: errors null location

    Hayata Suenaga committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    276f6e3 View commit details
    Browse the repository at this point in the history

  3. chore: remove redundant variable

    Hayata Suenaga committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    53a9514 View commit details
    Browse the repository at this point in the history

  4. chore: remove zero

    Hayata Suenaga committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    abcfc1e View commit details
    Browse the repository at this point in the history

  5. chore: use pendingFields

    Hayata Suenaga committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    8b777f1 View commit details
    Browse the repository at this point in the history

  6. chore: remove a const that is not used

    Hayata Suenaga committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    e2e37f2 View commit details
    Browse the repository at this point in the history

  7. don't lock required switch when the switch is on

    Hayata Suenaga committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    55cd7bb View commit details
    Browse the repository at this point in the history

  8. chore: add generic error

    Hayata Suenaga committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    3c18dd6 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. chore: add error fields

    Hayata Suenaga committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    7e5a4db View commit details
    Browse the repository at this point in the history

  2. chore: clear pending fields

    Hayata Suenaga committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    aa2127a View commit details
    Browse the repository at this point in the history

  3. fix: clear pending field

    Hayata Suenaga committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    cdd4b49 View commit details
    Browse the repository at this point in the history

  4. fix: display error from the error field

    Hayata Suenaga committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    144ed26 View commit details
    Browse the repository at this point in the history

  5. clear the error

    Hayata Suenaga committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    fbbca9d View commit details
    Browse the repository at this point in the history

  6. use action instead of fields 

    Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>
    @s77rt
    Hayata Suenaga and s77rt committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    fe47bb7 View commit details
    Browse the repository at this point in the history

  7. clear fields 

    Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>
    @s77rt
    Hayata Suenaga and s77rt committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    4a5851d View commit details
    Browse the repository at this point in the history

  8. clear the required field 

    Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>
    @s77rt
    Hayata Suenaga and s77rt committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    1f083ef View commit details
    Browse the repository at this point in the history

  9. fix: clear specific error field 

    Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>
    @s77rt
    Hayata Suenaga and s77rt committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    9752216 View commit details
    Browse the repository at this point in the history

  10. chore: define a function to clear a field error from policy tag list

    Hayata Suenaga committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    86685bd View commit details
    Browse the repository at this point in the history

  11. refactor: get orderWeight instead of the tag name

    Hayata Suenaga committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    b4422fb View commit details
    Browse the repository at this point in the history

  12. fix: the function parameter

    Hayata Suenaga committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    4fc37fb View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. chore: make clearPolicyTagErrors take tag list index

    Hayata Suenaga committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    7229be7 View commit details
    Browse the repository at this point in the history

  2. fix: use orderWeight from route params 

    Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>
    @s77rt
    Hayata Suenaga and s77rt committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    70f7c6b View commit details
    Browse the repository at this point in the history

  3. chore: pass missing argument to the clear error function

    Hayata Suenaga committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    1ca0837 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into hayata-add-requires-tags-button

    Hayata Suenaga committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    327cc7d View commit details
    Browse the repository at this point in the history

  5. fix: pass the missing argument to the function to clear the error

    Hayata Suenaga committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    83bca4b View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Merge branch 'main' into hayata-add-requires-tags-button

    Hayata Suenaga committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    d6f5800 View commit details
    Browse the repository at this point in the history

  2. only clear policy tag error when the items renders are policy tags 

    Co-authored-by: Abdelhafidh Belalia <16493223+s77rt@users.noreply.github.com>
    @s77rt
    Hayata Suenaga and s77rt committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    cdd4365 View commit details
    Browse the repository at this point in the history

  3. fix: lint issue

    Hayata Suenaga committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    050471f View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2024

  1. return of policy tag name is undefined

    Hayata Suenaga committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    bef9b95 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Merge branch 'main' of github.com:Expensify/App into hayata-add-requi… 

    …res-tags-button
    @aldo-expensify
    aldo-expensify committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    9b97a25 View commit details
    Browse the repository at this point in the history