fix: go back in AccessOrNotFoundWrapper #42976

tienifr · 2024-06-03T08:40:25Z

Details

This PR fixes the issue when going back in IOURequestStartPage when wrapped with AccessOrNotFoundWrapper.

Fixed Issues

$ #42902
$ #42906
PROPOSAL:

Tests

Log in with an account with no workspace
Deep link to send invoice page (e.g create/invoice/start/1/7783051691252045)
Click on the back icon of the not found RHP
Verify RHP dismisses with correct animation
Click on Settings
Verify app navigates to Settings page layout

Send the above invoice link to any chat then open it
Tap the back icon
Verify app navigates to the chat in step 7

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-06-03.at.15.44.38-compressed.mov

iOS: mWeb Safari

Screen.Recording.2024-06-03.at.15.45.48-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2024-06-03.at.15.41.14-compressed.mov

Screen.Recording.2024-06-03.at.15.40.57-compressed.mov

MacOS: Desktop

Untitled.mov

melvin-bot · 2024-06-03T08:42:29Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2024-06-03T08:42:50Z

@shubham1206agra Please review this as a follow-up of #41730.

shubham1206agra · 2024-06-03T15:22:12Z

@tienifr Can you write a summary why you have made such change?

tienifr · 2024-06-04T18:24:00Z

When we used /home as fallback route for goBack, it would navigate to that page directly using UP (to replace the current route):

App/src/libs/Navigation/Navigation.ts

Lines 219 to 222 in 2ebe8da

    
           if (shouldEnforceFallback || (isFirstRouteInNavigator && fallbackRoute)) { 
        
               navigate(fallbackRoute, CONST.NAVIGATION.TYPE.UP); 
        
               return; 
        
           }

/home belongs to BottomTabNavigator and we had a dedicated logic to push matching central pane route when navigating to it:

App/src/libs/Navigation/linkTo/index.ts

Line 132 in e9dc2ef

} else if (action.payload.name === NAVIGATORS.BOTTOM_TAB_NAVIGATOR) {

App/src/libs/Navigation/linkTo/index.ts

Line 143 in e9dc2ef

    
           // If the layout is wide we need to push matching central pane route to the stack.

We must not use /home with UP because that would skip the above logic and navigate directly to /home:

App/src/libs/Navigation/linkTo/index.ts

Lines 85 to 86 in e9dc2ef

    
           if (type === CONST.NAVIGATION.TYPE.UP) { 
        
               action.type = CONST.NAVIGATION.ACTION_TYPE.REPLACE;

That's why we only see the LHN (without the report) when going back from not found page as in #42906.

On the other hand, because we just want to go back to the previous page in stack, I think forcing fallback to ROUTES.HOME is redundant here.

tienifr · 2024-06-07T09:43:26Z

Bump @shubham1206agra

shubham1206agra · 2024-06-10T12:21:31Z

@tienifr Can you merge main here?

…42902

shubham1206agra · 2024-06-11T11:37:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-06-11.at.5.00.13.PM.mov

iOS: Native

Screen.Recording.2024-06-11.at.4.48.09.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-06-11.at.4.54.38.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-06-11.at.4.51.37.PM.mov

MacOS: Desktop

Screen.Recording.2024-06-11.at.5.02.56.PM.mov

OSBotify · 2024-06-11T20:38:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-11T22:28:29Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.82-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-06-13T15:31:05Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.82-4 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: go back in AccessOrNotFoundWrapper

98d6036

tienifr marked this pull request as ready for review June 3, 2024 08:42

tienifr requested a review from a team as a code owner June 3, 2024 08:42

melvin-bot bot removed the request for review from a team June 3, 2024 08:42

melvin-bot bot requested a review from shubham1206agra June 3, 2024 08:42

Merge branch 'main' of https://github.com/tienifr/App into fix/42906-…

59050d4

…42902

shubham1206agra approved these changes Jun 11, 2024

View reviewed changes

melvin-bot bot requested a review from youssef-lr June 11, 2024 11:38

youssef-lr approved these changes Jun 11, 2024

View reviewed changes

youssef-lr merged commit e9ed491 into Expensify:main Jun 11, 2024
16 checks passed

github-actions bot mentioned this pull request Jun 11, 2024

Deploy Checklist: New Expensify 2024-06-11 #43515

Closed

59 tasks

srikarparsi mentioned this pull request Jun 12, 2024

Revert "fix: go back in AccessOrNotFoundWrapper" #43604

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: go back in AccessOrNotFoundWrapper #42976

fix: go back in AccessOrNotFoundWrapper #42976

tienifr commented Jun 3, 2024 •

edited

Loading

melvin-bot bot commented Jun 3, 2024

tienifr commented Jun 3, 2024

shubham1206agra commented Jun 3, 2024

tienifr commented Jun 4, 2024 •

edited

Loading

tienifr commented Jun 7, 2024

shubham1206agra commented Jun 10, 2024

shubham1206agra commented Jun 11, 2024

OSBotify commented Jun 11, 2024

OSBotify commented Jun 11, 2024

OSBotify commented Jun 13, 2024

fix: go back in AccessOrNotFoundWrapper #42976

fix: go back in AccessOrNotFoundWrapper #42976

Conversation

tienifr commented Jun 3, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 3, 2024

tienifr commented Jun 3, 2024

shubham1206agra commented Jun 3, 2024

tienifr commented Jun 4, 2024 • edited Loading

tienifr commented Jun 7, 2024

shubham1206agra commented Jun 10, 2024

shubham1206agra commented Jun 11, 2024

Reviewer Checklist

Screenshots/Videos

OSBotify commented Jun 11, 2024

OSBotify commented Jun 11, 2024

OSBotify commented Jun 13, 2024

tienifr commented Jun 3, 2024 •

edited

Loading

tienifr commented Jun 4, 2024 •

edited

Loading