[ESM] Localize system messages #43079
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,26 +13,35 @@ import type { | |
| BeginningOfChatHistoryAnnounceRoomPartTwo, | ||
| BeginningOfChatHistoryDomainRoomPartOneParams, | ||
| CanceledRequestParams, | ||
| ChangeFieldParams, | ||
| ChangePolicyParams, | ||
| ChangeTypeParams, | ||
| CharacterLimitParams, | ||
| ConfirmThatParams, | ||
| DateShouldBeAfterParams, | ||
| DateShouldBeBeforeParams, | ||
| DelegateSubmitParams, | ||
| DeleteActionParams, | ||
| DeleteConfirmationParams, | ||
| DidSplitAmountMessageParams, | ||
| DistanceRateOperationsParams, | ||
| EditActionParams, | ||
| ElectronicFundsParams, | ||
| EnterMagicCodeParams, | ||
| ExportedToIntegrationParams, | ||
| FormattedMaxLengthParams, | ||
| ForwardedParams, | ||
| GoBackMessageParams, | ||
| GoToRoomParams, | ||
| InstantSummaryParams, | ||
| IntegrationsMessageParams, | ||
| LocalTimeParams, | ||
| LoggedInAsParams, | ||
| LogSizeParams, | ||
| ManagerApprovedAmountParams, | ||
| ManagerApprovedParams, | ||
| MarkedReimbursedParams, | ||
| MarkReimbursedFromIntegrationParams, | ||
| NewFaceEnterMagicCodeParams, | ||
| NoLongerHaveAccessParams, | ||
| NotAllowedExtensionParams, | ||
|
|
@@ -66,16 +75,20 @@ import type { | |
| SetTheRequestParams, | ||
| SettledAfterAddedBankAccountParams, | ||
| SettleExpensifyCardParams, | ||
| ShareParams, | ||
| SizeExceededParams, | ||
| SplitAmountParams, | ||
| StepCounterParams, | ||
| StripePaidParams, | ||
| TaskCreatedActionParams, | ||
| TermsParams, | ||
| ThreadRequestReportNameParams, | ||
| ThreadSentMoneyReportNameParams, | ||
| ToValidateLoginParams, | ||
| TransferParams, | ||
| TranslationBase, | ||
| UnapprovedParams, | ||
| UnshareParams, | ||
| UntilTimeParams, | ||
| UpdatedTheDistanceParams, | ||
| UpdatedTheRequestParams, | ||
|
|
@@ -2837,6 +2850,34 @@ export default { | |
| genericUpdateReportFieldFailureMessage: 'Unexpected error while updating the field, please try again later.', | ||
| genericUpdateReporNameEditFailureMessage: 'Unexpected error while renaming the report, please try again later.', | ||
| noActivityYet: 'No activity yet', | ||
| actions: { | ||
| type: { | ||
| changeField: ({oldValue, newValue, fieldName}: ChangeFieldParams) => `changed ${fieldName} from ${oldValue} to ${newValue}`, | ||
| changePolicy: ({fromPolicy, toPolicy}: ChangePolicyParams) => `changed policy from ${fromPolicy} to ${toPolicy}`, | ||
| changeType: ({oldType, newType}: ChangeTypeParams) => `changed type from ${oldType} to ${newType}`, | ||
| delegateSubmit: ({delegateUser, originalManager}: DelegateSubmitParams) => `sent this report to ${delegateUser} since ${originalManager} is on vacation`, | ||
| exportedToCSV: `exported this report to CSV`, | ||
| exportedToIntegration: ({label}: ExportedToIntegrationParams) => `exported this report to ${label}`, | ||
| forwarded: ({amount, currency}: ForwardedParams) => `approved ${currency}${amount}`, | ||
| // verify errorMessage | ||
| integrationsMessage: ({errorMessage}: IntegrationsMessageParams) => `failed to export this report to NetSuite. ${errorMessage}`, | ||
|
There was a problem hiding this comment. Just checking but |
||
| managerAttachReceipt: `added a receipt`, | ||
| managerDetachReceipt: `removed the receipt`, | ||
| markedReimbursed: ({amount, currency}: MarkedReimbursedParams) => `paid ${currency}${amount} elsewhere`, | ||
| markedReimbursedFromIntegration: ({amount, currency}: MarkReimbursedFromIntegrationParams) => `paid ${currency}${amount} via integration`, | ||
| outdatedBankAccount: `couldn’t process the payment due to a problem with the payer’s bank account`, | ||
| reimbursementACHBounce: `couldn’t process the payment, as the payer doesn’t have sufficient funds`, | ||
| reimbursementACHCancelled: `canceled the payment`, | ||
| reimbursementAccountChanged: `couldn’t process the payment, as the payer changed bank accounts`, | ||
| reimbursementDelayed: `processed the payment but it’s delayed by 1-2 more business days`, | ||
| selectedForRandomAudit: `[randomly selected](https://help.expensify.com/articles/expensify-classic/reports/Set-a-random-report-audit-schedule) for review`, | ||
|
There was a problem hiding this comment. For this olddot action, it shows a message in a plain text instead of converted markdown which caused the issue #45819 |
||
| share: ({to}: ShareParams) => `invited user ${to}`, | ||
| unshare: ({to}: UnshareParams) => `removed user ${to}`, | ||
| stripePaid: ({amount, currency}: StripePaidParams) => `paid ${currency}${amount}`, | ||
| takeControl: `took control`, | ||
| unapproved: ({amount, currency}: UnapprovedParams) => `unapproved ${currency}${amount}`, | ||
| }, | ||
| }, | ||
| }, | ||
| chronos: { | ||
| oooEventSummaryFullDay: ({summary, dayCount, date}: OOOEventSummaryFullDayParams) => `${summary} for ${dayCount} ${dayCount === 1 ? 'day' : 'days'} until ${date}`, | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you explicitly need these changes? If not, let's not include these.