Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce debounce time to 75ms when filtering search. #4311

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Reduce debounce time to 75ms when filtering search. #4311

merged 1 commit into from
Jul 30, 2021

Conversation

rushatgabhane
Copy link
Member

@rushatgabhane rushatgabhane commented Jul 29, 2021

Details

Comment

Fixed Issues

$ #3822

Tests / QA

  1. Login to New Expensify
  2. Use Command + K top open search.
  3. Type name of user to search really fast, and press enter.
  4. Verify that the chat is switched to searched user.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screencast.from.29-07-21.06_01_57.AM.+03.mp4

Mobile Web

Desktop

My.Movie.mp4

iOS

Screen.Recording.2021-07-29.at.10.57.21.PM.mov

Android

@rushatgabhane rushatgabhane requested a review from a team as a code owner July 29, 2021 19:52
@MelvinBot MelvinBot requested review from deetergp and removed request for a team July 29, 2021 19:52
Copy link
Contributor

@deetergp deetergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, thanks!

@deetergp deetergp merged commit 1557c80 into Expensify:main Jul 30, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.81-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to production in version: 1.0.82-7🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants