-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Onyx version to improve handling of defaultKeyStates #4312
Conversation
This is failing one of our tests. Going to put this back into draft while I check it out. |
Test is fixed. We've also merged another PR into |
Just updated it again to include the latest changes and seeing some improvements with chat switches on Android. Should be ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging in version: 1.0.81-5🚀
|
🚀 Deployed to production in version: 1.0.82-7🚀
|
Details
cc @kidroca updating the Onyx version to incorporate the latest changes regarding
defaultKeyStates
Notes:
There are two changes included in this PR under one sha
defaultKeyStates
PR - I ran some basic user timing tests around boot time and when the side bar first loads, but didn't notice anything worthy of reporting as far as performance improvements. We are viewing this as a pre-requisite to future improvements that should have a greater impact.Fixed Issues (Related)
#2667
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android