Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Onyx version to improve handling of defaultKeyStates #4312

Merged
merged 3 commits into from
Jul 30, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Jul 29, 2021

Details

cc @kidroca updating the Onyx version to incorporate the latest changes regarding defaultKeyStates

Notes:

There are two changes included in this PR under one sha

  • defaultKeyStates PR - I ran some basic user timing tests around boot time and when the side bar first loads, but didn't notice anything worthy of reporting as far as performance improvements. We are viewing this as a pre-requisite to future improvements that should have a greater impact.
  • The second PR for preventing unnecessary writes adds about 250ms to chat switching on Android release builds 🎉

Fixed Issues (Related)

#2667

Tests

QA Steps

  • Make sure the app initialize and runs OK
  • No specific test steps other than basic regressions and look out for errors when the app boots

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron requested a review from a team as a code owner July 29, 2021 19:59
@marcaaron marcaaron self-assigned this Jul 29, 2021
@MelvinBot MelvinBot requested review from Jag96 and removed request for a team July 29, 2021 19:59
@marcaaron
Copy link
Contributor Author

This is failing one of our tests. Going to put this back into draft while I check it out.

@marcaaron marcaaron marked this pull request as draft July 29, 2021 20:07
@marcaaron marcaaron marked this pull request as ready for review July 29, 2021 20:37
@marcaaron
Copy link
Contributor Author

Test is fixed. We've also merged another PR into react-native-onyx so going to bump this again in a bit.

@marcaaron
Copy link
Contributor Author

Just updated it again to include the latest changes and seeing some improvements with chat switches on Android. Should be ready for review now.

Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jag96 Jag96 merged commit 0f1d2d5 into main Jul 30, 2021
@Jag96 Jag96 deleted the marcaaron-defaultKeyStates branch July 30, 2021 00:16
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.81-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to production in version: 1.0.82-7🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants