Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different throw for Missing partnerUserSecret #4313

Merged
merged 2 commits into from
Jul 29, 2021
Merged

Conversation

joelbettner
Copy link
Contributor

@Expensify/pullerbear will you please review?

Details

This PR allows us to display the correct error message when a password of less than 4 characters is entered.

Fixed Issues

$ #4292

Tests

  1. Entered a password that was less than 4 characters long and confirmed I got the correct error message:
    image

QA

  1. Repeat the steps from the above test on Web, iOS and Android

@joelbettner joelbettner requested a review from a team July 29, 2021 21:04
@joelbettner joelbettner self-assigned this Jul 29, 2021
@MelvinBot MelvinBot requested review from tylerkaraszewski and removed request for a team July 29, 2021 21:04
Copy link
Contributor

@tylerkaraszewski tylerkaraszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, wrong quotation marks.

@joelbettner joelbettner requested a review from a team as a code owner July 29, 2021 21:26
@MelvinBot MelvinBot requested review from yuwenmemon and removed request for a team July 29, 2021 21:27
@yuwenmemon yuwenmemon merged commit 92eaaf8 into main Jul 29, 2021
@yuwenmemon yuwenmemon deleted the joel_402Login branch July 29, 2021 23:30
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.81-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Aug 6, 2021

🚀 Deployed to production in version: 1.0.82-7🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants