-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] e2e: fixed typing test #43178
Conversation
@yuwenmemon Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
}, 500); | ||
}; | ||
|
||
setFocus(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is a fix for an existing bug, does it mean that we need to increase the timeout that wraps it (currently 1ms)?
Could there be a cycling issue here?
I understand that this is for testing and wouldn't affect users, so this is just out of curiosity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is a fix for an existing bug, does it mean that we need to increase the timeout that wraps it (currently 1ms)?
No, we don't need. Sometimes it may work within 1ms, sometimes not - and in this case we give 500ms to be sure keyboard is opened (otherwise we blur input, set focus again and repeat the action).
Could there be a cycling issue here?
I did many tests and haven't discovered ant cycling here 👀
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coming from here lgtm
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.85-0 🚀
|
2 similar comments
🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.85-0 🚀
|
🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.85-0 🚀
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.85-7 🚀
|
Details
Fixed flaky
ReportTyping
test.Fixed Issues
$ #35225
PROPOSAL: N/A
Tests
Warning
Though probably test may fail for baseline build, because it will not have a new changes yet.
So it would be great to merge it straight before a new release to keep pipeline green 😁
Offline tests
N/A
QA Steps
Not needed.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop