Sage Intacct settings configuration: Advanced

[war-in]

Details

Fixed Issues

$ #43535
PROPOSAL:

Tests

1. Go to Accounting -> Advanced tab
2. Enable and disable Auto-sync. Verify there are no errors
3. Enable and disable Invite employees. Verify there are no errors
4. Enable and disable Sync reimbursed reports. Verify there are no errors
5. Enable Sync reimbursed reports and click on Sage Intacct payment account.
6. Choose one account and go back
7. Verify that chosen account is displayed under the Sync reimbursed reports text

To test errors add this line to the code (you can put it under the button)

Onyx.merge('policy_570EBAEF494D3C0A', {connections: {intacct: {config: {errorFields: {enabled: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.'}, importEmployees: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.'}, approvalMode: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.'}, syncReimbursedReports: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.'}, reimbursementAccountID: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.',},},},},},})

Offline tests

Enable force offline and

1. Go to Accounting -> Advanced tab
2. Click Auto-sync. Verify toggle is in offline state
3. Click Invite employees. Verify toggle is in offline state
4. Click Sync reimbursed reports. Verify toggle is in offline state
5. Enable Sync reimbursed reports and click on Sage Intacct payment account.
6. Choose one account and go back
7. Verify that chosen account is displayed under the Sync reimbursed reports text and component is in offline state

QA Steps

1. Go to Accounting -> Advanced tab
2. Enable and disable Auto-sync. Verify there are no errors
3. Enable and disable Invite employees. Verify there are no errors
4. Enable and disable Sync reimbursed reports. Verify there are no errors
5. Enable Sync reimbursed reports and click on Sage Intacct payment account.
6. Choose one account and go back
7. Verify that chosen account is displayed under the Sync reimbursed reports text

To test errors add this line to the code (you can put it under the button)

Onyx.merge('policy_570EBAEF494D3C0A', {connections: {intacct: {config: {errorFields: {enabled: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.'}, importEmployees: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.'}, approvalMode: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.'}, syncReimbursedReports: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.'}, reimbursementAccountID: {1: 'Oops... something went wrong and your request could not be completed. Please try again later.',},},},},},})

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.-.native.mov

android.-.natvie.mov

android.-.natvie.mov

Android: mWeb Chrome

android.-.web.mov

android.-.web.mov

android.-.web.mov

iOS: Native

ios.-.native.mov

ios.-.native.-.error.mov

ios.-.native.mov

iOS: mWeb Safari

ios.-.web.mov

ios.-.web.-.error.mov

ios.-.web.mov

MacOS: Chrome / Safari

web.mov

web.-.error.mov

web.mov

MacOS: Desktop

desktop.mov

desktop.-.error.mov

desktop.mov

[war-in]

Portion of translations :) I've created them using deepl. However I need help with verification 🙏 Posting them in Slack too

Auto-sync -> Sincronización automática
Sync Sage Intacct and Expensify automatically, every day. -> Sincronice Sage Intacct y Expensify automáticamente, todos los días.
Invite employees -> Invitar a los empleados
Import Sage Intacct employee records and invite employees to this workspace. Your approval workflow will default to manager approval and can be furthered configured on the Members page. -> Importe los registros de empleados de Sage Intacct e invite a los empleados a este espacio de trabajo. Su flujo de trabajo de aprobación será por defecto la aprobación del gerente y se puede configurar aún más en la página Miembros.
Sync reimbursed reports -> Sincronizar informes reembolsados
When a report is reimbursed using Expensify ACH, the corresponding puchase bill will be created in the Sage Intacct account below. -> Cuando un informe se reembolsa utilizando Expensify ACH, la factura de compra correspondiente se creará en la cuenta de Sage Intacct a continuación.
Sage Intacct payment account -> Cuenta de pago Sage Intacct
Not configured -> No configurado

[melvin-bot]

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[NikkiWines]

Couple small things and some NABs

[yuwenmemon]

NAB: does this need to be on a new line?

[war-in]

Unfortunately, yes. Prettier does that 🤷

[war-in]

@yuwenmemon @NikkiWines both reviews addressed 👍

Confirmed requested changes were addressed

[war-in]

@yuwenmemon Done :)

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.6-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.6-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[kavimuru]

@hungvu193 @yuwenmemon how do we test errors?

To test errors add this line to the code (you can put it under the button)

[hungvu193]

@hungvu193 @yuwenmemon how do we test errors?

To test errors add this line to the code (you can put it under the button)

You can open inspect on the web and paste that line into the console, and change the 570EBAEF494D3C0A to your workspace id and press Enter

Screen.Recording.2024-07-11.at.09.29.54.mov

[OSBotify]

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

[OSBotify]

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

[OSBotify]

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅