-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Revert "fix: re-calc the marker when msgs are deleted" #44247
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariUntitled.movMacOS: Chrome / SafariUntitled.movMacOS: Desktop |
I hope a verification video Web will be enough since this is straight revert, but let me know if we need i'll add it :) |
Overriding the missing checklist items, I have also verified web. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straight revert
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
I overrode the checklist, this was a revert |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Revert "fix: re-calc the marker when msgs are deleted" (cherry picked from commit f97782a)
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.1-6 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.1-19 🚀
|
Reverts #42742 to fix #44204
I verified that this deploy blocker is fixed with these changes.