Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove auto-complete for Industry Classification Code #4471

Merged
merged 3 commits into from
Aug 9, 2021

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Aug 6, 2021

Details

This fixes an issue where chrome will auto-complete for Industry Classification Code. This is the workaround that we follow in Web because Chrome will auto-populate the autoComplete data even if the autoComplete field is set to off. As an additional side-effect of this, we need to also remove the autoComplete for the ExpensifyPassword field.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/173177

Tests/QA

  1. Sign into an account on chrome and save the password in chrome when prompted
  2. Sign into an account, tap on the profile icon to go to settings, and then click on a workspace
  3. Click on Get Started for the Expensify Card
  4. Select Connect Manually and enter 123123123 for both fields
  5. On the autoComplete section, confirm no values are pre-filled for Industry Classification Code
  6. Confirm the same happens on all platforms (you won't be able to save password on the others)

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web/Desktop

@Jag96 Jag96 requested a review from a team as a code owner August 6, 2021 20:54
@Jag96 Jag96 self-assigned this Aug 6, 2021
@MelvinBot MelvinBot requested review from deetergp and removed request for a team August 6, 2021 20:54
Copy link
Contributor

@deetergp deetergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@deetergp deetergp merged commit 2c3ae05 into main Aug 9, 2021
@deetergp deetergp deleted the joe-auto-complete branch August 9, 2021 16:44
@OSBotify
Copy link
Contributor

OSBotify commented Aug 9, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @deetergp in version: 1.0.83-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @isagoico in version: 1.0.85-9 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@kevinksullivan
Copy link
Contributor

@Jag96 this has been working as expected in previous tests, but I just saw the auto-fill pop up again on staging. I have not seen it on prod though. Is that expected, or is there some regression taking place here?

image

@Jag96
Copy link
Contributor Author

Jag96 commented Aug 26, 2021

Looks like this is a regression, this change was undone in https://github.com/Expensify/App/pull/4765/files, will post in the other PR looks like it was broken on android so I'll just have a look

@Jag96 Jag96 mentioned this pull request Aug 26, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants