-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove auto-complete for Industry Classification Code #4471
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
@Jag96 this has been working as expected in previous tests, but I just saw the auto-fill pop up again on staging. I have not seen it on prod though. Is that expected, or is there some regression taking place here? |
Looks like this is a regression, this change was undone in https://github.com/Expensify/App/pull/4765/files, |
Details
This fixes an issue where chrome will auto-complete for Industry Classification Code. This is the workaround that we follow in Web because Chrome will auto-populate the autoComplete data even if the autoComplete field is set to
off
. As an additional side-effect of this, we need to also remove the autoComplete for the ExpensifyPassword field.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/173177
Tests/QA
Get Started
for the Expensify CardConnect Manually
and enter123123123
for both fieldsIndustry Classification Code
Tested On
Screenshots
Web/Desktop