-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: render Mapbox.MapView when access token is correctly set #44767
fix: render Mapbox.MapView when access token is correctly set #44767
Conversation
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@mountiny Can you run a build here? |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
@shubham1206agra what is your eta for the testing? |
Reviewer Checklist
Screenshots/VideosAndroid: NativeXRecorder_04072024_123941.mp4Android: mWeb ChromeNA iOS: NativeScreen.Recording.2024-07-07.at.8.20.59.PM.moviOS: mWeb SafariNA MacOS: Chrome / SafariNA MacOS: DesktopNA |
Updated branch with main |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/deetergp in version: 9.0.6-0 🚀
|
🚀 Deployed to staging by https://github.com/deetergp in version: 9.0.6-0 🚀
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀
|
Details
This fix applies only to the Android platform on low and mid-tier devices/emulator, where the backgrounded Exfy app is being killed to free up resources for a foreground app. Check on other platforms is required only to see if Map component works fine in any flow.
Fixed Issues
$ #43374
PROPOSAL: #43374 (comment)
Tests
Important: Tests needs to be done on low/mid-tier Android device or emulator and app has to get killed in the background
Offline tests
n/a
QA Steps
Important: Tests needs to be done on low/mid-tier Android device or emulator and app has to get killed in the background
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android-web.mov
iOS: Native
ios-new.mp4
iOS: mWeb Safari
ios-web-new.mp4
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov