Use centered modal for errors in the VBA flow in NewDot #4483
Conversation
There was a problem hiding this comment.
Changes look good but unsure if they are conflicting. Maybe @MitchExpensify @jasperhuangg knows for sure.
| @@ -66,47 +67,38 @@ class CompanyStep extends React.Component { | |||
| */ | |||
| validate() { | |||
| if (!this.state.password.trim()) { | |||
| Growl.error(this.props.translate('common.passwordCannotBeBlank')); | |||
There was a problem hiding this comment.
Just a quick question since I'm not really up to speed on this...
In this PR, we are replacing all these calls with red outlines and inline messages -> #4431
Do we need both a confirm modal and the inline messages?
There was a problem hiding this comment.
That's what I gathered from the solution mentioned in the issue.
Specific fields causing errors will be highlighted thanks to this change so we can use a generic message in the modal for all cases:
"Oops something went wrong! Please double check any highlighted fields and try again."
We can still wait for @MitchExpensify to confirm.
There was a problem hiding this comment.
Yes we're replacing all growls with centered modals as well as adding red field outlines.
|
Updated to address conflicts. |
|
it took 43mins to pass, |
Yes, it takes a long time to build the app for testing, but a necessary evil. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @marcaaron in version: 1.0.83-2 🚀
|
Details
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/171666#
Tests / QA
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android