Load recent waypoints on first sign in #45000

neil-marcellini · 2024-07-08T19:32:51Z

Details

When an account signs in and goes to create a distance expense, load their recent waypoints. That way if an account has previously created distance expenses, they can use their recent waypoints even if they signed out and back in since then. We only need to get this data into onyx once, because updates to the recent waypoints will be sent out every time a user creates another distance expense.

Fixed Issues

$ #43786
PROPOSAL: N/A

Tests

A. Existing recent waypoints load

Log into any account
Create a distance expense with waypoints A,B
Log out
Log back in
Create a distance expense again
Click on the blank start waypoint
Verify the waypoints A,B show as the top two recent waypoints
(dev only) Verify that there is one Network request OpenDraftDistanceExpense

B. Empty recent waypoints load

Log into a new account
Create a distance expense
Click on the blank start waypoint
Verify no recent waypoints are shown
(dev only) Verify that there is one Network request OpenDraftDistanceExpense

C. Recent waypoints load for distance tab only

Log into any account
Click the green plus, submit expense
Verify that the manual tab is selected
(dev only) Verify that there are 0 requests to OpenDraftDistanceExpense
Click the distance tab
(dev only) Verify that there is one Network request OpenDraftDistanceExpense

Verify that no errors appear in the JS console

Offline tests

A. Existing recent waypoints load

Log into any account
Create a distance expense with waypoints A,B
Log out
Log back in
Go offline
Create a distance expense again
Click on the blank start waypoint
Verify no recent waypoints are shown
Go back to the distance page
Go online
Click on the blank start waypoint
Verify the waypoints A,B show as the top two recent waypoints
(dev only) Verify that there is one successful Network request for the command OpenDraftDistanceExpense

B. Empty recent waypoints load

Log into a new account
Go offline
Create a distance expense
Click on the blank start waypoint
Verify no recent waypoints are shown
Go back to the distance page
Go online
Click on the blank start waypoint
Verify no recent waypoints are shown
(dev only) Verify that there is one successful Network request for the command OpenDraftDistanceExpense

QA Steps

Same as tests, skipping (dev only) steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

I only tested on web because the changes are platform independent.

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Online A

recent-waypoints1080.mov

Online B

no-recent-waypoints.mov

C

Screen.Recording.2024-07-15.at.4.29.56.PM.mov

Offline A

offlineA.mov

Offline B

offlineB.mov

MacOS: Desktop

melvin-bot · 2024-07-09T00:54:46Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

neil-marcellini · 2024-07-12T04:13:14Z

@hoangzinh this is off hold and ready for testing now.

hoangzinh · 2024-07-12T10:55:33Z

Yep @neil-marcellini I will try to review it today

hoangzinh · 2024-07-14T02:01:50Z

Overall, it looks good to me, I have just 1 small concern, at the moment, when the 1st time user submits expense after signing in, it always calls API to get recent waypoints, although user hasn't clicked on Distance expense yet. Is it acceptable behavior?

Screen.Recording.2024-07-14.at.06.27.05.mov

neil-marcellini · 2024-07-15T23:08:33Z

Ok @hoangzinh good point. I updated it to only make the request on the distance tab.

neil-marcellini · 2024-07-16T19:08:37Z

Ok, I got all the tests passing. Ready for another review.

hoangzinh · 2024-07-17T16:29:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-18.at.00.01.12.android.mov

Android: mWeb Chrome

Screen.Recording.2024-07-17.at.23.57.19.android.chrome.mov

iOS: Native

Screen.Recording.2024-07-18.at.00.09.11.ios.mov

iOS: mWeb Safari

Screen.Recording.2024-07-18.at.00.06.25.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-17.at.23.33.33.web.mov

MacOS: Desktop

Screen.Recording.2024-07-17.at.23.43.23.desktop.mov

melvin-bot · 2024-07-17T17:22:52Z

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

marcochavezf

LGTM

OSBotify · 2024-07-18T18:51:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-19T20:13:24Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.0.10-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-22T13:35:40Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.10-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-23T08:02:43Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.10-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-25T03:14:18Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.11-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

neil-marcellini added 4 commits July 8, 2024 09:52

Get recent waypoints when the distance page is first opened

29d2274

Fix recent waypoints key name to match backend

b021711

Handle loading state for recent waypoints

3166c42

One call to load recent waypoints, store loading state on account

77e380d

neil-marcellini self-assigned this Jul 8, 2024

neil-marcellini added 3 commits July 8, 2024 13:05

Simplify loading recent waypoints once

deb57d5

Offline support, only load recent waypoints online

f03f20a

Merge branch 'main' into neil-OpenDraftDistanceExpense

3963fa2

neil-marcellini changed the title ~~Load recent waypoints on first sign in~~ [HOLD Web-E 42658] Load recent waypoints on first sign in Jul 9, 2024

neil-marcellini added 2 commits July 8, 2024 17:48

Fix lint

e8aeb56

Define param type for new api command

ee63a6c

neil-marcellini marked this pull request as ready for review July 9, 2024 00:54

neil-marcellini requested a review from a team as a code owner July 9, 2024 00:54

melvin-bot bot requested review from hoangzinh and removed request for a team July 9, 2024 00:54

neil-marcellini changed the title ~~[HOLD Web-E 42658] Load recent waypoints on first sign in~~ Load recent waypoints on first sign in Jul 12, 2024

Only open draft distance expense on distance tab

44ec845

neil-marcellini added 4 commits July 15, 2024 16:35

Fix iouRequest type, get it with a util

360ec40

Revert change I missed for iouRequestType

8753bd0

Fix missing dependency/lint

c618b4b

Merge main to fix conflicts

3695146

hoangzinh approved these changes Jul 17, 2024

View reviewed changes

melvin-bot bot requested a review from marcochavezf July 17, 2024 17:22

marcochavezf approved these changes Jul 18, 2024

View reviewed changes

marcochavezf merged commit ffe311c into main Jul 18, 2024
15 checks passed

marcochavezf deleted the neil-OpenDraftDistanceExpense branch July 18, 2024 18:41

github-actions bot mentioned this pull request Jul 19, 2024

Deploy Checklist: New Expensify 2024-07-19 #45794

Closed

lanitochka17 mentioned this pull request Jul 20, 2024

[HOLD for payment 2024-09-03] [$250] Distance - Error displayed when creating distance expense in workspace that not opened yet #45856

Closed

6 tasks

hoangzinh mentioned this pull request Jul 24, 2024

[Awaiting payment a while ago] BUG: Recent waypoints aren't loaded after sign in #43786

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Load recent waypoints on first sign in #45000

Load recent waypoints on first sign in #45000

neil-marcellini commented Jul 8, 2024 •

edited

Loading

melvin-bot bot commented Jul 9, 2024

neil-marcellini commented Jul 12, 2024

hoangzinh commented Jul 12, 2024

hoangzinh commented Jul 14, 2024 •

edited

Loading

neil-marcellini commented Jul 15, 2024

neil-marcellini commented Jul 16, 2024

hoangzinh commented Jul 17, 2024 •

edited

Loading

melvin-bot bot commented Jul 17, 2024

marcochavezf left a comment

OSBotify commented Jul 18, 2024

OSBotify commented Jul 19, 2024

OSBotify commented Jul 22, 2024

OSBotify commented Jul 23, 2024

OSBotify commented Jul 25, 2024

Load recent waypoints on first sign in #45000

Load recent waypoints on first sign in #45000

Conversation

neil-marcellini commented Jul 8, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 9, 2024

neil-marcellini commented Jul 12, 2024

hoangzinh commented Jul 12, 2024

hoangzinh commented Jul 14, 2024 • edited Loading

neil-marcellini commented Jul 15, 2024

neil-marcellini commented Jul 16, 2024

hoangzinh commented Jul 17, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

melvin-bot bot commented Jul 17, 2024

marcochavezf left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 18, 2024

OSBotify commented Jul 19, 2024

OSBotify commented Jul 22, 2024

OSBotify commented Jul 23, 2024

OSBotify commented Jul 25, 2024

neil-marcellini commented Jul 8, 2024 •

edited

Loading

hoangzinh commented Jul 14, 2024 •

edited

Loading

hoangzinh commented Jul 17, 2024 •

edited

Loading