Update Onyx hash (LRU cache) #4509
Conversation
| "clipboard": "2.0.4", | ||
| "html-entities": "^1.3.1", | ||
| "jquery": "3.6.0", | ||
| "jquery": "3.3.1", |
There was a problem hiding this comment.
Is there a reason we're downgrading to an older release of jQuery?
There was a problem hiding this comment.
It happened automatically and it seem to be the correct version acording to package specification
Onyx uses Expensify/expensify-common@2e5cff5
- Onyx.package.json -> https://github.com/Expensify/react-native-onyx/blob/d7553b95e982ab78f6bb2064f6b0549f0ace94c2/package.json#L16
- That hash of
expensify-commonuses jQuery 3.3.1 -> https://github.com/Expensify/expensify-common/blob/2e5cff552cf132da90a3fb9756e6b4fb6ae7b40c/package.json#L24
Probably someone committed incorrect package-lock state
There was a problem hiding this comment.
Ah yeah, it looks like we aren't consistently updating repos with expensify-common dependencies after making changes in expensify-common.
I guess it's fine to merge this as-is... cc: @marcaaron just for awareness. I think we need to be more diligent with the follow-up PRs that Expensify employees should be making after changes to expensify-common.
There was a problem hiding this comment.
@kidroca you've got some conflicts now sorry but overall looks good
kidroca
force-pushed
the
kidroca/onyx-lru-cache
branch
from
6863843 to
5e80b64
Compare
|
Fixed conflicts and re-tested |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @NikkiWines in version: 1.0.83-2 🚀
|
|
This has been deployed to production and is now subject to a 7-day regression period. |
Details
Update to use latest Onyx version
Related to PR: Expensify/react-native-onyx#93
Fixed Issues
N/A
Tests
No specific tests. But a general tests for regressions
Init and chat switch performance should be the same or improved slightly
QA Steps
Same as "Tests"
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android