Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update e-common #4511

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Update e-common #4511

merged 1 commit into from
Aug 9, 2021

Conversation

parasharrajat
Copy link
Member

Details

Fixed Issues

$ #4187

Tests | QA Steps

  1. Paste Formatted links into the composer.
  2. You should receive the values based on the following rules:
    a. [html](www.google.com) When <a href="www.google.com">html</a> and you will see this type of link as html.
    b. www.google.com when <a href="www.google.com">www.google.com</a> and you will see this type of link as www.google.com.
    c. abc@gmail.com when<a href="mailto:abc@gmail.com">abc@gmail.com</a> and visible as abc@gmail.com.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

@parasharrajat parasharrajat requested a review from a team as a code owner August 9, 2021 18:37
@MelvinBot MelvinBot requested review from Luke9389 and removed request for a team August 9, 2021 18:37
@Luke9389 Luke9389 merged commit 6808fd1 into Expensify:main Aug 9, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Aug 9, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Luke9389 in version: 1.0.83-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@botify
Copy link

botify commented Aug 17, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-08-24. 🎊

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @isagoico in version: 1.0.85-9 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants