Add Live Markdown refactor changes #45150

Skalakid · 2024-07-10T13:25:12Z

Details

This PR contains bump to the new version of react-native-live-markdown from Expensify/react-native-live-markdown#394. The changes in this PR are temporary and were added only for QA testing purposes. The bump was added as a package.tgz file because of some problems with linking the branch/commit to package.json.

In this PR to Expensify, we want to check huge structure and logic changes in Live Markdown for the web before merging them in the library and enabling them inside the app. For more specific info please visit original PR.

The refactor was made as a part of the Inline Image feature. We needed to change the current Live Markdown Input logic and structure to enable displaying images inside the input. Also, we decided to enhance the current library implementation to:

enable new possibilities during the development, for example now we can use all possible styles inside the input without creating any critical bugs connected to text parsing and infinite new line generation
improve performance and quality of algorithms behind web markdown parsing and cursor positioning
simplify the code base for external contributors

Fixed Issues

Helps with #40181
$ #48581
PROPOSAL:

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Refactor was made only for web/mWeb/desktop platforms, please test only these platforms.
Since it's a big change it would be great to test it in all cases connected to:

Adding text / Markdown
Selection
Cursor positioning
Number of lines
Scroll into view
Placeholder
History - undo/redo
Pasting
Copy / Cut
Composition events
- Web:
  - Diacritics
  - Text replacement on mac
- mWeb:
  - Diacritics
  - Autocorrection
Spellcheck
- Web:
  - Chrome
  - Safari
  - Firefox (not working)
- mWeb:
  - iOS Safari
  - Android Chrome
And any other scenario that comes to your mind...

Test steps from #47763 (version 0.1.116):

Go to NewDot app
Click on the Green plus Icon
Click on Assign task
Insert a sample title
Click on Description
Insert multiple-line text until a scroll bar is shown on the right
On a new line insert a markdown text (eg. bold)8.Hit the enter key on the keyboard

Verify that: When hitting the enter key after a mark down the new line becomes visible with the cursor seen visibly

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-07-10T19:50:23Z

@dubielzyk-expensify @Ollyws One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Skalakid · 2024-07-10T19:55:55Z

This PR contains only temporary changes, added only for QA team regression tests. After this PR pass all the tests we will merge the refactor PR to library and than bump the version in this PR to the latest

…id/live-markdown-for-web-refactor

github-actions · 2024-07-11T12:52:23Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Desktop build failed	The QR code can't be generated, because the web build failed

👀 View the workflow run that generated this build 👀

github-actions · 2024-07-11T14:55:39Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/45150/index.html
The QR code can't be generated, because the android build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/45150/NewExpensify.dmg	https://45150.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mountiny · 2024-07-11T16:48:58Z

Requested the QA for this

izarutskaya · 2024-07-12T09:13:57Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Chat - Console error when selecting emoji from suggestion list

Version Number: 9.0.6-1
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Go to https://45150.pr-testing.expensify.com/
Go to any chat.
Enter :bla
Select the first emoji from the list.
Might need to repeat Step 3 and 4 a few times with different emoji to get the console error.

Expected Result:

No console error will show up.

Actual Result:

Console error shows up.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6539655_1720756941589.bandicam_2024-07-12_11-52-04-691.mp4

Bug6539655_1720756941618!45150.pr-testing.expensify.com-1720756341776.txt

Upwork Automation - Do Not Edit

izarutskaya · 2024-07-12T09:23:36Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Chat - Text pasted into the composer doubles if the user returns from a thread

Version Number: 9.0.6-2
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Navigate to https://45150.pr-testing.expensify.com/
Log in with any account
Navigate to FAB - Start chat
Open a chat with any member
Send any message
Right click on the message
Click on "Reply in thread"
Click on the header to return to the main chat
Right click on the message again
Click on "Copy to clipboard"
Paste the text into the composer

Expected Result:

The copied text should be pasted into the composer.

Actual Result:

Text pasted into the composer doubles if the user returns from a thread. Affects all chats after the issue is triggered.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6539658_1720757397506.bandicam_2024-07-12_05-57-32-630.mp4

Upwork Automation - Do Not Edit

izarutskaya · 2024-07-12T09:33:08Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Chat - Line breaks are added after each line to the text pasted from a code editor

Version Number: 9.0.6-2
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Navigate to https://45150.pr-testing.expensify.com/
Log in with any account
Navigate to FAB - Start chat
Open a chat with any member

Open this link in a new tab:

App/src/components/TextInputFocusable/index.js

Lines 263 to 267 in 403fc28

    
           if (files.length > 0) { 
        
               // Prevent the default so we do not post the file name into the text box 
        
               event.preventDefault(); 
        
               this.props.onPasteFile(event.clipboardData.files[0]); 
        
               return;

Copy the highlighted contect
Paste it into the composer

Expected Result:

The text in the composer should look like in the code editor.

Actual Result:

Line breaks are added after each line to the text pasted to the composer from a code editor

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6539665_1720758073198.bandicam_2024-07-12_06-16-19-296.mp4

Upwork Automation - Do Not Edit

izarutskaya · 2024-07-12T09:40:36Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

"Nothing to show" popup is over appearing over "Skeleton"

Version Number: 9.0.6-1
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

PreCond: User has no drafts

Access https://45150.pr-testing.expensify.com/
Sign into a valid account
Go to Inbox > Drafts

Expected Result:

User expects to see the "nothing to show" popup with a blank background. User does not expect a Skeleton WITH a popup as well.

Actual Result:

There is a "Skeleton" with the popup showing over it

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6539668_1720758724836!On_Staging_and_prod_

Upwork Automation - Do Not Edit

izarutskaya · 2024-07-12T09:45:12Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Task/IOU - Unable to paste content to description field

Version Number: 9.0.6-1
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Go to https://45150.pr-testing.expensify.com/
Copy any any content
Click on FAB > Assign task
Paste content in the description field

Expected Result:

The copied content is pasted in the description field and displayed

Actual Result:

The copied content is not pasted and not displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6539672_1720758981416.Recording__592.mp4

Upwork Automation - Do Not Edit

izarutskaya · 2024-07-12T09:55:14Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Expense - Empty line is created before and after the text in the code block in description

Version Number: 9.0.6-1
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Go to https://45150.pr-testing.expensify.com/
Go to DM.
Click + > Submit expense > Manual.
Submit a manual expense with code block in the description.
Go to transaction thread.
Click on the description.

Expected Result:

There will be no changes to the code block in the description.

Actual Result:

Empty line is created before and after the text in the code block in expense description.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6539676_1720759711940.bandicam_2024-07-12_12-44-39-410.mp4

Upwork Automation - Do Not Edit

izarutskaya · 2024-07-12T10:16:58Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Expense - Cursor moves to the front of emoji after selecting emoji in description field

Version Number: 9.0.6-1
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

Device must be a Windows window.

Go to 45150.pr-testing.expensify.com
Go to DM.
Click + > Submit expense > Manual.
Enter amount > Go to confirmation page.
Click Description.
Enter any text.
Open Windows emoji picker via CTRL + (.)
Select any emoji.
Note that the cursor moves to the front of the emoji.

Expected Result:

The cursor will move to the end of the description content.

Actual Result:

The cursor moves to the front of the emoji after selecting an emoji.
This issue is only reproducible on Windows devices, not Mac.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6539699_1720763160370.bandicam_2024-07-12_13-38-53-755.mp4

Recording.2620.mp4

Upwork Automation - Do Not Edit

izarutskaya · 2024-07-12T10:20:55Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Composer - Cursor moves in front of emoji if emoji inserted by using :emoji:

Version Number: 9.0.6-1
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

Go to https://45150.pr-testing.expensify.com/
and log in
Open any report
In the composer type :emoji name: , e.g 😄

Expected Result:

The cursor is displayed after the emoji

Actual Result:

The cursor moves in front of the emoji

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6539682_1720761187759.video_2024-07-12_01-12-42.mp4

Upwork Automation - Do Not Edit

Skalakid · 2024-08-20T10:18:51Z

@mountiny @IuliiaHerets All reported bugs should be fixed now and we got rid of all critical bugs connected to refactored architecture and logic of Live Markdown for web. How about moving forward with refactor and merging the changes in react-native-live-markdown library (PR) and then bumping the version in E/App?

Skalakid · 2024-08-20T10:57:43Z

@mountiny can you run the build last time, so we can confirm that everything has been fixed, please?

mvtglobally · 2024-08-20T15:51:11Z

Regression is completed

Skalakid · 2024-08-21T08:05:58Z

@mountiny @Ollyws @dubielzyk-expensify @thienlnam The Live Markdown refactor has been finally merged inside the library! Because of this, I removed temporary changes made for QA testing purposes and bumped the version of react-native-live-markdown to 0.1.117. The PR is ready for C+ and internal review. Also, we can remove the HOLD label ;)

Ollyws · 2024-08-21T10:54:21Z

👍 Will review later today or tomorrow

mountiny · 2024-08-21T15:40:13Z

@Ollyws Can you please tag me in slack when you are done

Ollyws · 2024-08-21T19:06:20Z

The cut button doesn't seem to be working for me on iOS Safari, however it's working fine on main:

cut_not_working.mov

mountiny · 2024-08-21T20:27:49Z

@Ollyws Are you able to put this to the top of your priorities? Just so we can get it merged as soon as possible, thank you!

Ollyws · 2024-08-21T20:29:29Z

Yeah sure, I'm reviewing at the moment.

Ollyws · 2024-08-21T21:17:53Z

Another issue I'm getting is on Android Chrome the selection is immediately being lost:

androidselectionproblem.mov

Skalakid · 2024-08-22T12:28:50Z

@Ollyws I can't reproduce the second bug on Android Chrome :/ Can you please delete node modules, run npm i, and check again, please?

Screen.Recording.2024-08-22.at.14.03.46.mov

Ollyws · 2024-08-22T15:13:07Z

I can't reproduce the second bug on Android Chrome :/ Can you please delete node modules, run npm i, and check again, please?

Ah it seems to be specific to that emulator and API I was using so I guess it's an issue with the emulator itself, we can forget about that one.

Ollyws · 2024-08-22T15:45:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

N/A

Android: mWeb Chrome

02_Android_Chrome.mp4

iOS: Native

N/A

iOS: mWeb Safari

04_iOS_Safari.mp4

MacOS: Chrome / Safari

05_MacOS_Chrome.mp4

MacOS: Desktop

06_MacOS_Desktop.mp4

Ollyws

Aside from #45150 (comment) which is being dealt with in Expensify/react-native-live-markdown#459, the rest LGTM.

thienlnam · 2024-08-22T16:50:49Z

Let's do it!!!

OSBotify · 2024-08-22T17:10:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-26T23:17:57Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 9.0.25-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-08-27T00:08:19Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 9.0.25-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Add react-native-live-markdown refactor for testing

499f5ea

Skalakid marked this pull request as ready for review July 10, 2024 19:50

Skalakid requested a review from a team as a code owner July 10, 2024 19:50

melvin-bot bot requested review from dubielzyk-expensify and Ollyws and removed request for a team July 10, 2024 19:50

mountiny assigned Skalakid Jul 10, 2024

mountiny added the Ready To Build label Jul 10, 2024

This comment has been minimized.

Sign in to view

Skalakid added 2 commits July 11, 2024 10:24

Merge branch 'main' into @Skalakid/live-markdown-for-web-refactor

560cae0

Merge branch '@Skalakid/bump-react-native-live-markdown' into @Skalak…

7af6e67

…id/live-markdown-for-web-refactor

Skalakid force-pushed the @Skalakid/live-markdown-for-web-refactor branch from 434c4fa to 7af6e67 Compare July 11, 2024 12:43

Skalakid added 2 commits July 11, 2024 14:44

Merge branch 'main' into @Skalakid/live-markdown-for-web-refactor

46671b2

pod install

1b0fa24

mountiny requested review from thienlnam and mountiny July 11, 2024 14:39

Merge branch 'main' into @Skalakid/live-markdown-for-web-refactor

7d1726d

Skalakid added 2 commits August 21, 2024 09:42

Bump react-native-live-markdown version to 0.1.117

765899e

Merge branch 'main' into @Skalakid/live-markdown-for-web-refactor

0b6f704

thienlnam changed the title ~~[HOLD - will be merged as part of the live markdown update] Add Live Markdown refactor changes~~ Add Live Markdown refactor changes Aug 21, 2024

Skalakid mentioned this pull request Aug 22, 2024

Fix cursor selection event on the web Expensify/react-native-live-markdown#459

Merged

Ollyws approved these changes Aug 22, 2024

View reviewed changes

thienlnam approved these changes Aug 22, 2024

View reviewed changes

thienlnam merged commit 91305a8 into Expensify:main Aug 22, 2024
20 checks passed

Skalakid mentioned this pull request Aug 23, 2024

fix[live-md bump]: scroll to new line after hit Enter key #47763

Closed

50 tasks

github-actions bot mentioned this pull request Aug 26, 2024

Deploy Checklist: New Expensify 2024-08-26 #48035

Closed

This was referenced Aug 28, 2024

[Awaiting Payment 4th October] [$125] mWeb - Chat - While editing composer doesn't hide and the editing input doesn't get focused #48161

Closed

Web - Chat - Edited gets copied after selecting and copying an edited comment #48200

Closed

puneetlath mentioned this pull request Aug 28, 2024

Deploy Checklist: New Expensify 2024-08-28 #48221

Closed

93 tasks

thienlnam mentioned this pull request Sep 4, 2024

[$250] Payment for #45150 #48581

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Live Markdown refactor changes #45150

Add Live Markdown refactor changes #45150

Skalakid commented Jul 10, 2024 •

edited by thienlnam

Loading

melvin-bot bot commented Jul 10, 2024

Skalakid commented Jul 10, 2024

This comment has been minimized.

github-actions bot commented Jul 11, 2024

github-actions bot commented Jul 11, 2024

mountiny commented Jul 11, 2024

izarutskaya commented Jul 12, 2024 •

edited

Loading

izarutskaya commented Jul 12, 2024

izarutskaya commented Jul 12, 2024

izarutskaya commented Jul 12, 2024

izarutskaya commented Jul 12, 2024

izarutskaya commented Jul 12, 2024

izarutskaya commented Jul 12, 2024

izarutskaya commented Jul 12, 2024

Skalakid commented Aug 20, 2024

Skalakid commented Aug 20, 2024

mvtglobally commented Aug 20, 2024

Skalakid commented Aug 21, 2024

Ollyws commented Aug 21, 2024

mountiny commented Aug 21, 2024

Ollyws commented Aug 21, 2024

mountiny commented Aug 21, 2024

Ollyws commented Aug 21, 2024

Ollyws commented Aug 21, 2024

Skalakid commented Aug 22, 2024

Ollyws commented Aug 22, 2024

Ollyws commented Aug 22, 2024

Ollyws left a comment •

edited

Loading

thienlnam commented Aug 22, 2024

OSBotify commented Aug 22, 2024

OSBotify commented Aug 26, 2024

OSBotify commented Aug 27, 2024

Add Live Markdown refactor changes #45150

Add Live Markdown refactor changes #45150

Conversation

Skalakid commented Jul 10, 2024 • edited by thienlnam Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 10, 2024

Skalakid commented Jul 10, 2024

This comment has been minimized.

github-actions bot commented Jul 11, 2024

github-actions bot commented Jul 11, 2024

mountiny commented Jul 11, 2024

izarutskaya commented Jul 12, 2024 • edited Loading

Chat - Console error when selecting emoji from suggestion list

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

izarutskaya commented Jul 12, 2024

Chat - Text pasted into the composer doubles if the user returns from a thread

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

izarutskaya commented Jul 12, 2024

Chat - Line breaks are added after each line to the text pasted from a code editor

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

izarutskaya commented Jul 12, 2024

"Nothing to show" popup is over appearing over "Skeleton"

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

izarutskaya commented Jul 12, 2024

Task/IOU - Unable to paste content to description field

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

izarutskaya commented Jul 12, 2024

Expense - Empty line is created before and after the text in the code block in description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

izarutskaya commented Jul 12, 2024

Expense - Cursor moves to the front of emoji after selecting emoji in description field

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

izarutskaya commented Jul 12, 2024

Composer - Cursor moves in front of emoji if emoji inserted by using :emoji:

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Skalakid commented Jul 10, 2024 •

edited by thienlnam

Loading

izarutskaya commented Jul 12, 2024 •

edited

Loading

Ollyws left a comment •

edited

Loading