[CP Staging] fix: frequent component re-mount #45335

kirillzyusko · 2024-07-12T12:43:14Z

Details

The problem happens when re-render happens (shown keyboard can be one of the trigger, since we store that data in the context).

When re-render from App.tsx level comes, then:

we'll re-execute () => { from freezeScreenWithLazyLoading
we'll re-invoke HOC and it'll create a new component and thus we'll remount entire tree.

Since this function handles screen-level entities -> we'll re-mount entire screen. keyboard appear -> we re-mount screen -> we destroy composer -> we loose focus -> keyboard hides. When screen is mounted -> we retrieve input focus and we get infinite loop 🤯

To fix this I decided to memoize the output of freezeScreenWithLazyLoading. I think that how it was designed to work, i. e. cache once and then return cached instance of the component.

Fixed Issues

https://expensify.slack.com/archives/C01GTK53T8Q/p1720776606394749
$ #45152
PROPOSAL: N/A

Tests

On Android

Open any chat
Make sure keyboard is open and screen is not updated every second and keyboard stays on the screen without attempting to hide and appear again;

Offline tests

N/A

QA Steps

On Android

Open any chat
Make sure keyboard is open and screen is not updated every second and keyboard stays on the screen without attempting to hide and appear again;

PR Author Checklist

Screenshots/Videos

Android: Native

telegram-cloud-document-2-5226817861695065883.mp4

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-07-12T12:43:42Z

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2024-07-12T12:49:00Z

In this case we'll re-execute () => { from freezeScreenWithLazyLoading, we'll re-invoke HOC and it'll create a new component and thus we'll remount entire tree.

Since this function handles screen-level entities -> we'll re-mount entire screen. Since we re-mount screen -> we destroy composer -> we loose focus -> keyboard hides. When screen is mounted -> we retrieve a focus and we get infinite loop 🤯

The RCA seems solid and accurate to me @kirillzyusko , Dope work !!

allgandalf · 2024-07-12T12:49:18Z

I have started to build iOS locally

Julesssss · 2024-07-12T13:38:53Z

Trying another build

allgandalf · 2024-07-12T13:51:22Z

I guess i found one bug from the PR, I will post it once i confirm that it doesn't happen on the staging app, ~10 minutes

github-actions · 2024-07-12T13:54:17Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/45335/NewExpensify.dmg	https://45335.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

allgandalf · 2024-07-12T13:55:18Z

Bug

Not able to post a message after i visit a report transaction on iOS Native:

Reproduction Steps:

Go to any chat
Submit 2 money requests there
Visit one of the money request
go back to main chat
try typing in the composer

Screen.Recording.2024-07-12.at.7.23.26.PM.mov

allgandalf · 2024-07-12T13:57:12Z

@kirillzyusko can you test on your side and confirm if this is reproducible ? the flickering issue doesn't happen anymore confirmed 👍

allgandalf · 2024-07-12T13:59:49Z

Note

I am able to post again if i reopen the chat from LHN
I also don't see this reproducible on web platforms

kirillzyusko · 2024-07-12T14:12:22Z

can you test on your side and confirm if this is reproducible ? the flickering issue doesn't happen anymore confirmed 👍

Yes, it's reproducible on my end

I also don't see this reproducible on web platforms

Because freezeScreenWithLazyLoading is used only on mobile 👀

github-actions · 2024-07-12T14:14:24Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/45335/NewExpensify.dmg	https://45335.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

allgandalf · 2024-07-12T14:15:48Z

Because freezeScreenWithLazyLoading is used only on mobile 👀

Smart !! 👀

github-actions · 2024-07-12T15:58:24Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/45335/NewExpensify.dmg	https://45335.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

allgandalf · 2024-07-12T17:24:11Z

seems to be fixed now @kirillzyusko 😌

Screen.Recording.2024-07-12.at.10.52.15.PM.mov

Can you try fix lint (Maybe put a exception there? idk if there is any such exception for Prettier diff)

allgandalf · 2024-07-12T17:28:17Z

wait no!! the send button is not functional on web now!!

allgandalf · 2024-07-12T17:30:36Z

Note that i can still send when i press enter button on keyboard so the button is disabled somehow:

Screen.Recording.2024-07-12.at.11.04.25.PM.mov

kirillzyusko · 2024-07-12T19:45:16Z

@allgandalf oh no! Will check web and CI tomorrow!

mountiny · 2024-07-12T20:44:58Z

Damn, sorry to see it did not work fully yet. Great job so far.

It feels like it might be better to try to investigate the rootcause or bisect where this happened first cause revert might be safer than some more complex not fully tested fix

github-actions · 2024-07-15T08:23:02Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/45335/NewExpensify.dmg	https://45335.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

src/pages/home/report/ReportActionCompose/useFreezeId/index.ts

allgandalf · 2024-07-15T08:40:51Z

@kirillzyusko , can you quickly move the useFreezeId in the hooks folder, or do you think you can come up with a follow up PR for that one ?

kirillzyusko · 2024-07-15T08:44:49Z

can you quickly move the useFreezeId in the hooks folder, or do you think you can come up with a follow up PR for that one?

No, I think I will do that in this PR 👀

allgandalf · 2024-07-15T08:45:20Z

cool, but lets wait for the perf tests to pass now :)))

allgandalf · 2024-07-15T08:58:35Z

@kirillzyusko did you test the latest changes on web? I am still able to reproduce the bug on web:

Screen.Recording.2024-07-15.at.2.28.13.PM.mov

kirillzyusko · 2024-07-15T09:00:57Z

@allgandalf yeah, I tested this, but it worked on my end. Let me reset cache and try again!

allgandalf · 2024-07-15T10:03:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-15.at.4.05.42.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-07-15.at.4.08.25.PM.mov

iOS: Native

Screen.Recording.2024-07-15.at.4.00.45.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-07-15.at.4.03.32.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-15.at.3.36.04.PM.mov

MacOS: Desktop

Screen.Recording.2024-07-15.at.3.41.17.PM.mov

This reverts commit 0b25d23.

This reverts commit 8224e3d.

This reverts commit d4b0885.

This reverts commit fb434e0.

…abled" This reverts commit 3f7cd2a.

allgandalf

I approve this change, the deploy blocker is solved by these changes, TESTS WELL ON ALL PLATFORMS!

thanks @kirillzyusko for the PR, this really pushed us to far, thanks for the back and forth too, had fun unblocking this, all yours @srikarparsi @mountiny 🙇

OSBotify · 2024-07-15T10:56:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

(cherry picked from commit 8198564)

OSBotify · 2024-07-15T11:40:43Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.6-4 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-15T13:59:33Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.6-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T16:36:25Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-15T17:09:24Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-15T20:28:47Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-17T00:25:55Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.7-8 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix: frequent component re-mount

fb47846

kirillzyusko requested a review from a team as a code owner July 12, 2024 12:43

melvin-bot bot removed the request for review from a team July 12, 2024 12:43

melvin-bot bot requested a review from srikarparsi July 12, 2024 12:43

fix: re-organize imports to avoid a crash

a600ac5

mountiny added the Ready To Build label Jul 12, 2024

mountiny self-requested a review July 12, 2024 12:50

mountiny changed the title ~~fix: frequent component re-mount~~ [CP Staging] fix: frequent component re-mount Jul 12, 2024

mountiny assigned kirillzyusko Jul 12, 2024

This comment has been minimized.

Sign in to view

mountiny mentioned this pull request Jul 12, 2024

Pick only params from route before passing them to screen #44531

Merged

50 tasks

fix: re-create GestureDetector after freeze being enabled/disabled

3f7cd2a

fix: revert accident changes

d4b0885

fix: reassure test

8224e3d

allgandalf reviewed Jul 15, 2024

View reviewed changes

src/pages/home/report/ReportActionCompose/useFreezeId/index.ts Outdated Show resolved Hide resolved

refactor: move hooks to separate folder

0b25d23

kirillzyusko added 5 commits July 15, 2024 12:15

Revert "refactor: move hooks to separate folder"

c775f92

This reverts commit 0b25d23.

Revert "fix: reassure test"

76c23d5

This reverts commit 8224e3d.

Revert "fix: revert accident changes"

4897887

This reverts commit d4b0885.

Revert "fix: eslint, disabled button on web"

db75cee

This reverts commit fb434e0.

Revert "fix: re-create GestureDetector after freeze being enabled/dis…

5492f90

…abled" This reverts commit 3f7cd2a.

allgandalf approved these changes Jul 15, 2024

View reviewed changes

mountiny approved these changes Jul 15, 2024

View reviewed changes

mountiny merged commit 8198564 into Expensify:main Jul 15, 2024
15 checks passed

OSBotify pushed a commit that referenced this pull request Jul 15, 2024

Merge pull request #45335 from margelo/fix/unexpected-unmount

87c06d2

(cherry picked from commit 8198564)

github-actions bot mentioned this pull request Jul 15, 2024

Deploy Checklist: New Expensify 2024-07-10 #45144

Closed

melvin-bot bot mentioned this pull request Jul 17, 2024

[HOLD for payment 2024-07-22] [$500] Android & iOS-Chat - Report flickers, keyboard is dismissed when focus on composer on Android #45152

Closed

6 tasks

allgandalf mentioned this pull request Jul 18, 2024

[CP Staging] Add freezeScreenWithLazyLoading function #44544

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] fix: frequent component re-mount #45335

[CP Staging] fix: frequent component re-mount #45335

kirillzyusko commented Jul 12, 2024 •

edited

Loading

melvin-bot bot commented Jul 12, 2024

allgandalf commented Jul 12, 2024

allgandalf commented Jul 12, 2024

This comment has been minimized.

Julesssss commented Jul 12, 2024 •

edited

Loading

allgandalf commented Jul 12, 2024

github-actions bot commented Jul 12, 2024

allgandalf commented Jul 12, 2024 •

edited

Loading

allgandalf commented Jul 12, 2024

allgandalf commented Jul 12, 2024 •

edited

Loading

kirillzyusko commented Jul 12, 2024

github-actions bot commented Jul 12, 2024

allgandalf commented Jul 12, 2024

github-actions bot commented Jul 12, 2024

allgandalf commented Jul 12, 2024 •

edited

Loading

allgandalf commented Jul 12, 2024

allgandalf commented Jul 12, 2024 •

edited

Loading

kirillzyusko commented Jul 12, 2024

mountiny commented Jul 12, 2024

github-actions bot commented Jul 15, 2024

allgandalf commented Jul 15, 2024 •

edited

Loading

kirillzyusko commented Jul 15, 2024

allgandalf commented Jul 15, 2024

allgandalf commented Jul 15, 2024

kirillzyusko commented Jul 15, 2024

allgandalf commented Jul 15, 2024 •

edited

Loading

allgandalf left a comment

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 17, 2024

[CP Staging] fix: frequent component re-mount #45335

[CP Staging] fix: frequent component re-mount #45335

Conversation

kirillzyusko commented Jul 12, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 12, 2024

allgandalf commented Jul 12, 2024

allgandalf commented Jul 12, 2024

This comment has been minimized.

Julesssss commented Jul 12, 2024 • edited Loading

allgandalf commented Jul 12, 2024

github-actions bot commented Jul 12, 2024

allgandalf commented Jul 12, 2024 • edited Loading

Bug

allgandalf commented Jul 12, 2024

allgandalf commented Jul 12, 2024 • edited Loading

kirillzyusko commented Jul 12, 2024

github-actions bot commented Jul 12, 2024

allgandalf commented Jul 12, 2024

github-actions bot commented Jul 12, 2024

allgandalf commented Jul 12, 2024 • edited Loading

allgandalf commented Jul 12, 2024

allgandalf commented Jul 12, 2024 • edited Loading

kirillzyusko commented Jul 12, 2024

mountiny commented Jul 12, 2024

github-actions bot commented Jul 15, 2024

allgandalf commented Jul 15, 2024 • edited Loading

kirillzyusko commented Jul 15, 2024

allgandalf commented Jul 15, 2024

allgandalf commented Jul 15, 2024

kirillzyusko commented Jul 15, 2024

allgandalf commented Jul 15, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allgandalf left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 15, 2024

OSBotify commented Jul 17, 2024

kirillzyusko commented Jul 12, 2024 •

edited

Loading

Julesssss commented Jul 12, 2024 •

edited

Loading

allgandalf commented Jul 12, 2024 •

edited

Loading

allgandalf commented Jul 12, 2024 •

edited

Loading

allgandalf commented Jul 12, 2024 •

edited

Loading

allgandalf commented Jul 12, 2024 •

edited

Loading

allgandalf commented Jul 15, 2024 •

edited

Loading

allgandalf commented Jul 15, 2024 •

edited

Loading