Add Export CSV and handle offline for all actions #45614

rlinoz · 2024-07-17T15:37:40Z

Details

Fixed Issues

$ #44576
PROPOSAL:

Tests

On Web:

Log in to the account with Search Data
Select a few items
Click on "X selected" button
Click "Download"
When offline you should see Modal with information otherwise the file will be downloaded

On native apps:

Log in to the account with Search Data
Select a few items
Click on "X selected" button
Verify no download button shows up

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-07-17.at.13.20.18.mov

MacOS: Desktop

github-actions · 2024-07-17T16:15:01Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/45614/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/45614/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/45614/NewExpensify.dmg	https://45614.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

melvin-bot · 2024-07-17T16:23:22Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane

@rlinoz copy update from - https://expensify.slack.com/archives/C036QM0SLJK/p1721235367578159?thread_ts=1721057271.106449&cid=C036QM0SLJK

src/languages/en.ts

src/languages/es.ts

rushatgabhane · 2024-07-17T16:59:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

Screen.Recording.2024-07-17.at.21.07.14.mov

MacOS: Chrome / Safari

MacOS: Desktop

rushatgabhane

Download is not working on desktop.

Be online
Select a few money requests from search
Click download

{code:666	jsonCode:666	type:Expensify\\Libs\\Error\\ExpError	UUID:10A4D01E-AE78-48B8-B14A-22D8CB59396F	message:Query was not provided.	title:	data:[]	htmlMessage:	requestID:8a4beb1a0afb6794-BAH}

Co-authored-by: Rushat Gabhane <rushatgabhane@gmail.com>

rlinoz · 2024-07-17T17:32:27Z

Oh @filip-solecki mentioned that here and I didn't test, lets go with the same approach of leaving it for the follow up.

rushatgabhane · 2024-07-17T17:58:11Z

@rlinoz we should not show the download button then. could you please commit a .index.desktop.tsx file

rushatgabhane

LGTM

melvin-bot · 2024-07-17T18:09:06Z

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2024-07-17T18:18:48Z

@rlinoz whoops this should be a .tsx file, and not .ts

rlinoz · 2024-07-17T18:35:43Z

Updated, thanks for catching that! 🙇

luacmartins

Looking good. Left a few small comments

src/components/Search/SearchListWithHeader.tsx

src/components/Search/SearchPageHeader.tsx

src/languages/en.ts

src/libs/actions/Search.ts

Co-authored-by: Carlos Martins <cmartins@expensify.com>

luacmartins · 2024-07-17T19:55:50Z

Looks like my suggestion broke everything, sorry! 😅

OSBotify · 2024-07-17T22:35:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-18T14:14:15Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.9-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-19T11:56:56Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.9-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-19T19:39:17Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.9-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-23T08:05:37Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.10-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

filip-solecki and others added 11 commits July 16, 2024 11:59

Add Export CSV and handle offline for all actions

6822a4f

Change request type

4514185

Revert fileDownload function changes

2c69e75

Add back empty line

6c77fa8

CR fixes

a91b592

Add confirmed translations

ed50d80

Review fixes

4653dc6

Merge branch 'main' into search/export-csv-items

1dba225

Use POST method

ae6e2c4

Fix TS

c4dc4aa

adding modal for download error and removing download option outside web

fa2ccf6

rlinoz added the Ready To Build label Jul 17, 2024

lint + prettier

6f15214

rlinoz self-assigned this Jul 17, 2024

luacmartins self-requested a review July 17, 2024 16:21

rlinoz marked this pull request as ready for review July 17, 2024 16:23

rlinoz requested a review from a team as a code owner July 17, 2024 16:23

melvin-bot bot requested review from rushatgabhane and removed request for a team July 17, 2024 16:23

rushatgabhane suggested changes Jul 17, 2024

View reviewed changes

src/languages/en.ts Outdated Show resolved Hide resolved

src/languages/es.ts Outdated Show resolved Hide resolved

rushatgabhane suggested changes Jul 17, 2024

View reviewed changes

rlinoz and others added 2 commits July 17, 2024 14:30

Update src/languages/en.ts

0e7b879

Co-authored-by: Rushat Gabhane <rushatgabhane@gmail.com>

Update src/languages/es.ts

990d6d9

Co-authored-by: Rushat Gabhane <rushatgabhane@gmail.com>

rlinoz added 2 commits July 17, 2024 15:04

Merge remote-tracking branch 'origin/main' into rodrigo-fix-download-csv

471b4e6

removing download option from desktop

a48397d

rushatgabhane approved these changes Jul 17, 2024

View reviewed changes

melvin-bot bot requested a review from cristipaval July 17, 2024 18:09

fix extension

389409b

luacmartins requested changes Jul 17, 2024

View reviewed changes

Update src/languages/en.ts

0815754

Co-authored-by: Carlos Martins <cmartins@expensify.com>

rlinoz added 2 commits July 17, 2024 16:56

fix language

340e922

pr comments

8885dc5

rlinoz requested a review from luacmartins July 17, 2024 22:07

luacmartins approved these changes Jul 17, 2024

View reviewed changes

luacmartins merged commit 7bb89e1 into main Jul 17, 2024
14 checks passed

luacmartins deleted the rodrigo-fix-download-csv branch July 17, 2024 22:25

github-actions bot mentioned this pull request Jul 18, 2024

Deploy Checklist: New Expensify 2024-07-18 #45680

Closed

61 tasks

melvin-bot bot mentioned this pull request Jul 19, 2024

[HOLD for payment 2024-07-26] [CSV] Add Download action to Search page #44576

Closed

rushatgabhane mentioned this pull request Feb 11, 2025

[PAID 02/19] [Support CSV] Create import flow for tags #47870

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Export CSV and handle offline for all actions #45614

Add Export CSV and handle offline for all actions #45614

rlinoz commented Jul 17, 2024 •

edited

Loading

github-actions bot commented Jul 17, 2024

melvin-bot bot commented Jul 17, 2024

rushatgabhane left a comment •

edited

Loading

rushatgabhane commented Jul 17, 2024 •

edited

Loading

rushatgabhane left a comment

rlinoz commented Jul 17, 2024 •

edited

Loading

rushatgabhane commented Jul 17, 2024 •

edited

Loading

rushatgabhane left a comment

melvin-bot bot commented Jul 17, 2024

rushatgabhane commented Jul 17, 2024 •

edited

Loading

rlinoz commented Jul 17, 2024

luacmartins left a comment

luacmartins commented Jul 17, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 18, 2024

OSBotify commented Jul 19, 2024

OSBotify commented Jul 19, 2024

OSBotify commented Jul 23, 2024

Add Export CSV and handle offline for all actions #45614

Add Export CSV and handle offline for all actions #45614

Conversation

rlinoz commented Jul 17, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

github-actions bot commented Jul 17, 2024

melvin-bot bot commented Jul 17, 2024

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

rushatgabhane commented Jul 17, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane left a comment

Choose a reason for hiding this comment

rlinoz commented Jul 17, 2024 • edited Loading

rushatgabhane commented Jul 17, 2024 • edited Loading

rushatgabhane left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jul 17, 2024

rushatgabhane commented Jul 17, 2024 • edited Loading

rlinoz commented Jul 17, 2024

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins commented Jul 17, 2024

OSBotify commented Jul 17, 2024

OSBotify commented Jul 18, 2024

OSBotify commented Jul 19, 2024

OSBotify commented Jul 19, 2024

OSBotify commented Jul 23, 2024

rlinoz commented Jul 17, 2024 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

rushatgabhane commented Jul 17, 2024 •

edited

Loading

rlinoz commented Jul 17, 2024 •

edited

Loading

rushatgabhane commented Jul 17, 2024 •

edited

Loading

rushatgabhane commented Jul 17, 2024 •

edited

Loading