Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Revert "[RN 0.74 Upgrade] Upgrade react-native-pager-view to 6.3.3" #45782

Merged
merged 1 commit into from
Jul 19, 2024
Merged

[CP Staging] Revert "[RN 0.74 Upgrade] Upgrade react-native-pager-view to 6.3.3" #45782

merged 1 commit into from
Jul 19, 2024

Conversation

rlinoz
Copy link
Contributor

@rlinoz rlinoz commented Jul 19, 2024 •
edited
Loading

Reverts #45573

$ #45693

VIDEO-2024-07-19-11-58-47.mp4

@rlinoz rlinoz marked this pull request as ready for review July 19, 2024 14:51
@rlinoz rlinoz requested a review from a team as a code owner July 19, 2024 14:51
@melvin-bot melvin-bot bot requested review from marcochavezf and removed request for a team July 19, 2024 14:51
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jul 19, 2024

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions GitHub Actions
Copy link
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/45782/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/45782/index.html
Android iOS
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/45782/NewExpensify.dmg https://45782.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@rlinoz rlinoz merged commit 388a3fe into main Jul 19, 2024
26 of 31 checks passed
@rlinoz rlinoz deleted the revert-45573-feat/upgrade-react-native-pager-view branch July 19, 2024 15:04
@melvin-bot melvin-bot bot added the Emergency label Jul 19, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Jul 19, 2024

@rlinoz looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@rlinoz rlinoz changed the title Revert "[RN 0.74 Upgrade] Upgrade react-native-pager-view to 6.3.3" [CP Stagin] Revert "[RN 0.74 Upgrade] Upgrade react-native-pager-view to 6.3.3" Jul 19, 2024
@rlinoz rlinoz changed the title [CP Stagin] Revert "[RN 0.74 Upgrade] Upgrade react-native-pager-view to 6.3.3" [CP Staging] Revert "[RN 0.74 Upgrade] Upgrade react-native-pager-view to 6.3.3" Jul 19, 2024
@rlinoz rlinoz removed the Emergency label Jul 19, 2024
@rlinoz
Copy link
Contributor Author

rlinoz commented Jul 19, 2024 •
edited
Loading

Straight revert to fix a deploy blocker, no need for a checklist.

@rlinoz rlinoz mentioned this pull request Jul 19, 2024
Merged
50 tasks
OSBotify pushed a commit that referenced this pull request Jul 19, 2024
@rlinoz @OSBotify
Merge pull request #45782 from Expensify/revert-45573-feat/upgrade-re…
3d38211 
…act-native-pager-view

Revert "[RN 0.74 Upgrade] Upgrade react-native-pager-view to 6.3.3"

(cherry picked from commit 388a3fe)
@github-actions github-actions bot mentioned this pull request Jul 19, 2024
Closed
61 tasks
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.9-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.9-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.9-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.10-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikkiWines NikkiWines NikkiWines approved these changes

@marcochavezf marcochavezf Awaiting requested review from marcochavezf

Assignees

@rlinoz rlinoz

Labels
Ready To Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rlinoz @OSBotify @NikkiWines @luacmartins