feat: upload native logs #45905

kirillzyusko · 2024-07-22T13:01:12Z

Details

Added newly crafted react-native-app-logs library to intercept logs from NotificationService and re-use rich JS logging ecosystem (to send logs to server for further debugging).

Fixed Issues

$ #42659
PROPOSAL: N/A

Tests

send push notification
be sure that log statement from swift can be discovered in logs on server side

Offline tests

N/A

QA Steps

send push notification
be sure that log statement from swift can be discovered in logs on server side

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

arosiclair · 2024-09-13T17:02:22Z

@kirillzyusko I'm trying to test locally, but I'm seeing this error when I run your branch on web:

Uncaught Error: The package 'react-native-app-logs' doesn't seem to be linked. Make sure: 

- You rebuilt the app after installing the package
- You are not using Expo Go

    at Object.get (index.mjs:19:11)
    at eval (index.mjs:37:34)
    at ./node_modules/react-native-app-logs/lib/module/index.mjs (vendors-88386e6117bfcd5e30e5.bundle.js:27536:1)
    at __webpack_require__ (runtime-f27aceca70c021039e62.bundle.js:36:33)
    at fn (runtime-f27aceca70c021039e62.bundle.js:337:21)
    at eval (Log.ts:8:79)
    at ./src/libs/Log.ts (main-9c81a2a4dfa33730e8bf.bundle.js:8400:1)
    at __webpack_require__ (runtime-f27aceca70c021039e62.bundle.js:36:33)
    at fn (runtime-f27aceca70c021039e62.bundle.js:337:21)
    at eval (Navigation.ts:8:67)

Do we need to only import this module on native?

kirillzyusko · 2024-09-16T11:00:26Z

@arosiclair let me check it!

kirillzyusko · 2024-09-16T14:10:50Z

@arosiclair I fixed build issues/compatibility with RN 0.73 - would you mind to check again?

Now both native iOS and web should work without ant problems!

arosiclair · 2024-09-16T19:47:42Z

I am still seeing the same errors. Unit tests are also failing for the same reason:

  ● Test suite failed to run

    The package 'react-native-app-logs' doesn't seem to be linked. Make sure: 

    - You have run 'pod install'
    - You rebuilt the app after installing the package
    - You are not using Expo Go

      4 | /* eslint-disable rulesdir/no-api-in-views */
      5 | import {Logger} from 'expensify-common';
    > 6 | import AppLogs from 'react-native-app-logs';

kirillzyusko · 2024-09-16T20:05:03Z

@arosiclair can you show the content of react-native-app-logs (especially lib folder and package.json file) in node_modules? Just thinking if you are downloading latest version or not?

arosiclair · 2024-09-16T20:48:06Z

@arosiclair can you show the content of react-native-app-logs (especially lib folder and package.json file) in node_modules? Just thinking if you are downloading latest version or not?

arosiclair@BigMac margelo % cat node_modules/react-native-app-logs/package.json 
{
  "name": "react-native-app-logs",
  "version": "0.1.0",
  "description": "Access native logs from JS code",
  "source": "./src/index.tsx",
  "main": "./lib/commonjs/index.cjs",
  "module": "./lib/module/index.mjs",
  "types": "./lib/typescript/src/index.d.ts",
  "react-native": "./src/index",
  "exports": {
    ".": {
      "types": "./lib/typescript/src/index.d.ts",
      "import": "./lib/module/index.mjs",
      "require": "./lib/commonjs/index.cjs"
    }
  },
  "files": [
    "src",
    "lib",
    "android",
    "ios",
    "cpp",
    "AppLogsPod",
    "*.podspec",
    "!ios/build",
    "!android/build",
    "!android/gradle",
    "!android/gradlew",
    "!android/gradlew.bat",
    "!android/local.properties",
    "!**/__tests__",
    "!**/__fixtures__",
    "!**/__mocks__",
    "!**/.*"
  ],
  "scripts": {
    "example": "yarn workspace react-native-app-logs-example",
    "test": "jest",
    "typecheck": "tsc --noEmit",
    "lint": "eslint \"**/*.{js,ts,tsx}\"",
    "clean": "del-cli android/build example/android/build example/android/app/build example/ios/build lib",
    "prepare": "bob build",
    "release": "release-it"
  },
  "keywords": [
    "react-native",
    "ios",
    "android"
  ],
  "repository": {
    "type": "git",
    "url": "git+https://github.com/kirillzyusko/react-native-app-logs.git"
  },
  "author": "Kiryl Ziusko <kiryl@margelo.io> (https://github.com/kirillzyusko)",
  "license": "MIT",
  "bugs": {
    "url": "https://github.com/kirillzyusko/react-native-app-logs/issues"
  },
  "homepage": "https://github.com/kirillzyusko/react-native-app-logs#readme",
  "publishConfig": {
    "registry": "https://registry.npmjs.org/"
  },
  "devDependencies": {
    "@commitlint/config-conventional": "^17.0.2",
    "@evilmartians/lefthook": "^1.5.0",
    "@react-native/eslint-config": "^0.73.1",
    "@release-it/conventional-changelog": "^5.0.0",
    "@types/jest": "^29.5.5",
    "@types/react": "^18.2.44",
    "commitlint": "^17.0.2",
    "del-cli": "^5.1.0",
    "eslint": "^8.51.0",
    "eslint-config-prettier": "^9.0.0",
    "eslint-plugin-prettier": "^5.0.1",
    "jest": "^29.7.0",
    "prettier": "^3.0.3",
    "react": "18.2.0",
    "react-native": "0.74.3",
    "react-native-builder-bob": "^0.25.0",
    "release-it": "^15.0.0",
    "turbo": "^1.10.7",
    "typescript": "^5.2.2"
  },
  "resolutions": {
    "@types/react": "^18.2.44"
  },
  "peerDependencies": {
    "react": "*",
    "react-native": "*"
  },
  "workspaces": [
    "example"
  ],
  "packageManager": "yarn@3.6.1",
  "jest": {
    "preset": "react-native",
    "modulePathIgnorePatterns": [
      "<rootDir>/example/node_modules",
      "<rootDir>/lib/"
    ]
  },
  "commitlint": {
    "extends": [
      "@commitlint/config-conventional"
    ]
  },
  "release-it": {
    "git": {
      "commitMessage": "chore: release ${version}",
      "tagName": "v${version}"
    },
    "npm": {
      "publish": true
    },
    "github": {
      "release": true
    },
    "plugins": {
      "@release-it/conventional-changelog": {
        "preset": "angular"
      }
    }
  },
  "eslintConfig": {
    "root": true,
    "extends": [
      "@react-native",
      "prettier"
    ],
    "rules": {
      "react/react-in-jsx-scope": "off",
      "prettier/prettier": [
        "error",
        {
          "quoteProps": "consistent",
          "singleQuote": true,
          "tabWidth": 2,
          "trailingComma": "es5",
          "useTabs": false
        }
      ]
    }
  },
  "eslintIgnore": [
    "node_modules/",
    "lib/"
  ],
  "prettier": {
    "quoteProps": "consistent",
    "singleQuote": true,
    "tabWidth": 2,
    "trailingComma": "es5",
    "useTabs": false
  },
  "react-native-builder-bob": {
    "source": "src",
    "output": "lib",
    "targets": [
      [
        "commonjs",
        {
          "esm": true
        }
      ],
      [
        "module",
        {
          "esm": true
        }
      ],
      [
        "typescript",
        {
          "project": "tsconfig.build.json"
        }
      ]
    ]
  },
  "codegenConfig": {
    "name": "RNAppLogsSpec",
    "type": "modules",
    "jsSrcsDir": "src"
  },
  "create-react-native-library": {
    "type": "module-mixed",
    "languages": "kotlin-objc",
    "version": "0.38.1"
  }
}

package.json

kirillzyusko · 2024-09-16T21:05:31Z

./lib/commonjs/index.cjs

@arosiclair it's an old code 😔 Can you try to download latest version of the code?

arosiclair · 2024-09-17T16:26:11Z

Same error even with the commit hash. Unit tests are broken for the same reason as well. There's something wrong with the way we added this package. Can you try reproducing the issue so you can investigate? The problem isn't fixed until unit tests start passing.

I see the version in your repo has not changed from 0.1.0 I would start looking at that.

kirillzyusko · 2024-09-18T13:09:45Z

@arosiclair I pushed new changes - now everything should be working. Unit-tests are not failing anymore, I changed version to 0.2.0, so everything should be working now!

arosiclair · 2024-09-18T20:04:15Z

Thanks web is working now.

One more thing to fix: the notification service is not added to the app group on this branch. I updated it locally and the logs started showing in JS. Can you merge the latest from main? The app groups should already be set correctly there.

src/libs/Log.ts

ios/NotificationServiceExtension/NotificationService.swift

src/libs/Log.ts

melvin-bot · 2024-09-19T16:22:20Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/Log.ts

arosiclair · 2024-09-20T19:58:42Z

Code LGTM, but push notifications are not working in my dev environment for some reason now so I can't do a final test. I reached out to Airship about it. Hopefully we hear back about it or maybe it'll just start working next week.

kirillzyusko · 2024-09-23T09:57:01Z

Code LGTM, but push notifications are not working in my dev environment for some reason now so I can't do a final test. I reached out to Airship about it. Hopefully we hear back about it or maybe it'll just start working next week.

Okay, waiting 👀

arosiclair · 2024-09-26T19:49:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

iOS: Native

arosiclair

Alright this is working well! However there's one issue here:

Where the reportActionID gets logged as <private>. We should be able to fix that by updating the log format strings. We just need to update these two

and replace %@ with %{public}@

src/libs/Log.ts

kirillzyusko · 2024-09-30T08:50:04Z

@arosiclair thanks! I applied all requested changes - would you mind to check again? 👀

arosiclair

Thanks for the changes 👍

OSBotify · 2024-10-01T15:12:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-02T00:31:15Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.0.43-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-02T01:09:55Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.0.43-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

arosiclair · 2024-10-02T13:45:54Z

Internal QA ✅

It's working! [PushNotification] Notification Service - logs are visible in logSearch

github-actions · 2024-10-03T03:34:06Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.43-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kirillzyusko mentioned this pull request Jul 22, 2024

[HOLD for payment 2024-11-11] [HOLD for payment 2024-11-05] [$250] Upload logs from Swift code #42659

Closed

6 tasks

kirillzyusko force-pushed the feat/swift-logs-github branch from 72bb25a to 0f7cd8d Compare September 3, 2024 15:33

arosiclair assigned kirillzyusko Sep 13, 2024

kirillzyusko force-pushed the feat/swift-logs-github branch from 0f7cd8d to 38657a4 Compare September 16, 2024 14:06

arosiclair reviewed Sep 16, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

arosiclair requested changes Sep 18, 2024

View reviewed changes

src/libs/Log.ts Outdated Show resolved Hide resolved

ios/NotificationServiceExtension/NotificationService.swift Show resolved Hide resolved

src/libs/Log.ts Outdated Show resolved Hide resolved

src/libs/Log.ts Show resolved Hide resolved

kirillzyusko force-pushed the feat/swift-logs-github branch from c175c25 to 1614e6b Compare September 19, 2024 13:10

kirillzyusko marked this pull request as ready for review September 19, 2024 16:22

kirillzyusko requested a review from a team as a code owner September 19, 2024 16:22

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team September 19, 2024 16:22

kirillzyusko requested a review from arosiclair September 20, 2024 14:36

arosiclair requested changes Sep 20, 2024

View reviewed changes

src/libs/Log.ts Outdated Show resolved Hide resolved

src/libs/Log.ts Outdated Show resolved Hide resolved

kirillzyusko requested a review from arosiclair September 20, 2024 15:09

arosiclair requested changes Sep 20, 2024

View reviewed changes

src/libs/Log.ts Outdated Show resolved Hide resolved

arosiclair requested changes Sep 26, 2024

View reviewed changes

src/libs/Log.ts Outdated Show resolved Hide resolved

kirillzyusko added 14 commits September 30, 2024 10:27

feat: intercept logs from NotificationService

be3d872

fix: use latest package version

35c1874

fix: update Podfile.lock, change group name

da7fb93

fix: app-logs compatibility with RN 0.73

92787f5

fix: specify exact commit

f209a25

fix: specify hash in package.json again

34c7cb8

fix: unit tests

72ee76b

fix: use hmmm for .error level

a4765f6

fix: bump app-logs

0447d3b

fix: use [PushNotification] NotificationService - ... format

af6dcab

fix: apply suggested changes

f657190

fix: keep comments capitalized

cd52763

fix: make specific data visible in logs by default

a41df3c

fix: update Podfile.lock

9dfdb39

kirillzyusko force-pushed the feat/swift-logs-github branch from a78b8bc to 9dfdb39 Compare September 30, 2024 08:42

kirillzyusko requested a review from arosiclair September 30, 2024 09:01

arosiclair approved these changes Oct 1, 2024

View reviewed changes

arosiclair merged commit 8f08755 into Expensify:main Oct 1, 2024
18 checks passed

arosiclair added the InternalQA This pull request required internal QA label Oct 1, 2024

github-actions bot mentioned this pull request Oct 2, 2024

Deploy Checklist: New Expensify 2024-10-02 #50030

Closed

56 tasks

hannojg mentioned this pull request Oct 2, 2024

[HOLD for payment 2024-10-11] [HOLD for payment 2024-10-10] Investigate workflow job failing on main: e2ePerformanceTests / Build apk from latest release as a baseline #50031

Closed

roryabraham deleted the feat/swift-logs-github branch October 2, 2024 21:36

jasperhuangg mentioned this pull request Oct 3, 2024

[CP Staging] Revert "feat: upload native logs" #50124

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: upload native logs #45905

feat: upload native logs #45905

kirillzyusko commented Jul 22, 2024 •

edited

Loading

arosiclair commented Sep 13, 2024

kirillzyusko commented Sep 16, 2024

kirillzyusko commented Sep 16, 2024

arosiclair commented Sep 16, 2024

kirillzyusko commented Sep 16, 2024

arosiclair commented Sep 16, 2024

kirillzyusko commented Sep 16, 2024

arosiclair commented Sep 17, 2024

kirillzyusko commented Sep 18, 2024

arosiclair commented Sep 18, 2024

melvin-bot bot commented Sep 19, 2024

arosiclair commented Sep 20, 2024

kirillzyusko commented Sep 23, 2024

arosiclair commented Sep 26, 2024 •

edited

Loading

arosiclair left a comment

kirillzyusko commented Sep 30, 2024

arosiclair left a comment

OSBotify commented Oct 1, 2024

github-actions bot commented Oct 2, 2024

github-actions bot commented Oct 2, 2024

arosiclair commented Oct 2, 2024 •

edited

Loading

github-actions bot commented Oct 3, 2024

feat: upload native logs #45905

feat: upload native logs #45905

Conversation

kirillzyusko commented Jul 22, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

arosiclair commented Sep 13, 2024

kirillzyusko commented Sep 16, 2024

kirillzyusko commented Sep 16, 2024

arosiclair commented Sep 16, 2024

kirillzyusko commented Sep 16, 2024

arosiclair commented Sep 16, 2024

kirillzyusko commented Sep 16, 2024

arosiclair commented Sep 17, 2024

kirillzyusko commented Sep 18, 2024

arosiclair commented Sep 18, 2024

melvin-bot bot commented Sep 19, 2024

arosiclair commented Sep 20, 2024

kirillzyusko commented Sep 23, 2024

arosiclair commented Sep 26, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

arosiclair left a comment

Choose a reason for hiding this comment

kirillzyusko commented Sep 30, 2024

arosiclair left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 1, 2024

github-actions bot commented Oct 2, 2024

github-actions bot commented Oct 2, 2024

arosiclair commented Oct 2, 2024 • edited Loading

github-actions bot commented Oct 3, 2024

kirillzyusko commented Jul 22, 2024 •

edited

Loading

arosiclair commented Sep 26, 2024 •

edited

Loading

arosiclair commented Oct 2, 2024 •

edited

Loading