-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assign CP PRs to the deployer that triggered them #4602
Conversation
Ohh this is going to be really hard to QA since we have to actually modify files. Do you have any suggestions of what files we could modify? Maybe a README file or something? Should we simply hope for the best and see if it works when this happens? Also, I just discovered we have a CP label haha |
@pecanoro Yes! I'd also say changing a README file is the easiest way to test this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple things here:
- In order to add or adjust the inputs or outputs of a GH action, we need to also adjust the action metadata file
- Now that this action it doing more than getting the merge commit for a pull request, we should rename it to something more generic, perhaps just
getPullRequestDetails
- I do wonder if there's an existing community action to just get all the details for an arbitrary pull request. If so, we could maybe use that and get rid of this custom action altogether.
The only community action I found is this one, which doesn't look like it has all the outputs we need. So there are two choices: Continue with our own custom action, include only the outputs we need, and rename it do something more generic like OR
|
Up to you which you prefer! |
I'm going to go with the first option, as we have this custom logic related to the OSBotify actor, and we would still need a custom action for that. |
Is it ready for another review? I see you updated the PR |
Co-authored-by: Rory Abraham <47436092+roryabraham@users.noreply.github.com>
All yours @pecanoro |
@HorusGoul this is going to need internal QA – we know that it didn't break the CP flow (because we ran a CP this morning), but we still need to verify that it works as expected. Not going to block the deploy on this because there's no good reason to - it doesn't affect any of the app code. |
🚀 Deployed to production by @roryabraham in version: 1.0.93-1 🚀
|
Details
Adds a new step in the cherry-pick job to assign the deployer to the PR with conflicts that need to be fixed manually.
Fixed Issues
$ #4036
Tests/QA Steps
CP Staging
label.CP Staging
label.