Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Add Hermes Profiling tips to Performance.md #4617

Merged
merged 3 commits into from
Sep 2, 2021

Conversation

marcaaron
Copy link
Contributor

Details

Just adding some tips for how to profile JS on an Android or iOS device.

Fixed Issues

No Issue

Tests

QA Steps

None

@marcaaron marcaaron self-assigned this Aug 12, 2021
@marcaaron marcaaron requested a review from a team as a code owner August 12, 2021 19:01
@MelvinBot MelvinBot requested review from cead22 and removed request for a team August 12, 2021 19:01
@cead22 cead22 merged commit a919ee8 into main Sep 2, 2021
@cead22 cead22 deleted the marcaaron-addProfilingInstructions branch September 2, 2021 17:50
@OSBotify
Copy link
Contributor

OSBotify commented Sep 2, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Sep 3, 2021

🚀 Deployed to staging by @cead22 in version: 1.0.92-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Sep 4, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.93-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants