Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes SearchActionOptionsUtils file #46220

Merged
merged 3 commits into from
Jul 25, 2024
+15 −31
Merged

Removes SearchActionOptionsUtils file #46220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80b738a
removing SearchActionOptionsUtils file
rlinoz Jul 25, 2024
1d8a80f
merge main
rlinoz Jul 25, 2024
1710fc3
rollback ios files
rlinoz Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions src/components/Search/SearchActionOptionsUtils.tsx
View file
Open in desktop

This file was deleted.

30 changes: 15 additions & 15 deletions src/components/Search/SearchPageHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import ROUTES from '@src/ROUTES';
import type {SearchReport} from '@src/types/onyx/SearchResults';
import type DeepValueOf from '@src/types/utils/DeepValueOf';
import type IconAsset from '@src/types/utils/IconAsset';
import getDownloadOption from './SearchActionOptionsUtils';
import {useSearchContext} from './SearchContext';
import type {SearchStatus, SelectedTransactions} from './types';

Expand Down Expand Up @@ -74,22 +73,23 @@ function SearchPageHeader({

const options: Array<DropdownOption<SearchHeaderOptionValue>> = [];

// Because of some problems with the lib we use for download on native we are only enabling download for web, we should remove the SearchActionOptionsUtils files when https://github.com/Expensify/App/issues/45511 is done
const downloadOption = getDownloadOption(translate('common.download'), () => {
if (isOffline) {
setOfflineModalOpen?.();
return;
}

SearchActions.exportSearchItemsToCSV(status, selectedReports, selectedTransactionsKeys, [activeWorkspaceID ?? ''], () => {
setDownloadErrorModalOpen?.();
});
options.push({
icon: Expensicons.Download,
text: translate('common.download'),
value: CONST.SEARCH.BULK_ACTION_TYPES.EXPORT,
shouldCloseModalOnSelect: true,
onSelected: () => {
if (isOffline) {
setOfflineModalOpen?.();
return;
}

SearchActions.exportSearchItemsToCSV(status, selectedReports, selectedTransactionsKeys, [activeWorkspaceID ?? ''], () => {
setDownloadErrorModalOpen?.();
});
},
});

if (downloadOption) {
options.push(downloadOption);
}

const shouldShowHoldOption = !isOffline && selectedTransactionsKeys.every((id) => selectedTransactions[id].canHold);

if (shouldShowHoldOption) {
Expand Down
Loading