fix clicking pay button for invoices raise an null error #46317

jacobkim9881 · 2024-07-26T16:58:19Z

Details

This change will set a value as "" for ref.current.value. Whenever event handler accesses popover component to popover, the value should have been set on React Native at iOS environments. Before the change, the value was falsy like null or undefined.

Fixed Issues

$ #44919
PROPOSAL: $ #44919 (comment)

Tests

From user A, click + of composer and click a send invoice in a workspace.
Put any number for fee and create a invoice on the workspace.
From user B, in the workspace click the pay button for the invite.
Check if there is an error.

Verify that no errors appear in the JS console

Offline tests

Online from user A, click + of composer and click a send invoice in a workspace.
Put any number for fee and create a invoice on the workspace.
Offline from user B, in the workspace click the pay button for the invite.
Check if there is an error.

QA Steps

test1

Click FAB and click submit expense
Put amount and click next and check an error occurred on amount page
Select any account and next on participants page
Click confirmation button on confirmation page
Check an error occurred

test2

Click money request preview at test1 or any chat report.
In details view click header to go parent report and to go header details page
Check an error occurred

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

44919-android_20240716_165355_New.Expensify.Dev.mov

Android: mWeb Chrome

44919-android-mw_20240716_191503_Chrome.mov

iOS: Native

ios-44919.2024-07-08.3.48.49.mov

iOS: mWeb Safari

44919-.ios.mw.2024-07-16.9.08.09.mov

MacOS: Chrome / Safari

web-44919.2024-07-16.8.50.07.mov

MacOS: Desktop

desktop-44919.2024-07-16.5.18.49.mov

melvin-bot · 2024-07-26T17:50:03Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jacobkim9881 · 2024-07-26T18:09:19Z

@rushatgabhane For clean pull request history from unverified commits, I created a new branch and asked to pull request. Please to review this pull request.

rushatgabhane

@jacobkim9881 this is failing typescript checks.

Please fix errors for npm run typecheck and npm run lint

jacobkim9881 · 2024-07-28T04:26:08Z

@rushatgabhane I've added commit for type check and lint. Please to check the pr.

rushatgabhane · 2024-07-28T04:29:34Z

@jacobkim9881 i don't think we need to create a new utility function. How are null checks done in other places of the app?

jacobkim9881 · 2024-07-28T05:43:42Z

@rushatgabhane I understood. Deleted the utility function and put null check back.

rushatgabhane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-26.at.06.31.11.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-07-26.at.06.30.21.mov

iOS: mWeb Safari

Screen.Recording.2024-07-26.at.06.32.25.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-26.at.06.29.38.mov

MacOS: Desktop

Gonals · 2024-07-31T16:14:50Z

Got some conflicts!

jacobkim9881 · 2024-07-31T16:50:46Z

The pr haven't updated lastest production.

Pushed a commit with updated one.

@rushatgabhane please to review the pr.

Gonals · 2024-08-02T09:59:34Z

Seems like performance tests are failing, but I'm not positive it is the PR's fault. Can you take a look?

jacobkim9881 · 2024-08-02T10:21:19Z

Oh, I have checked the patch file(patch file react-native+0.73.4+023+textinput-clear-command.patch) has been deleted on lated version so I have merged latest version into this branch. Please to review the branch.

OSBotify · 2024-08-02T12:41:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-06T04:28:02Z

🚀 Deployed to staging by https://github.com/Gonals in version: 9.0.17-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-07T22:03:52Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-08T04:53:29Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-08T20:04:53Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jacobkim9881 added 2 commits July 27, 2024 01:19

fix: null check instead of setting an empty value

5a7e6a3

Merge branch 'main' of https://github.com/Expensify/App into 44919

267c7be

jacobkim9881 mentioned this pull request Jul 26, 2024

fix clicking pay button for invoices raise an null error #45484

Closed

50 tasks

fix: type check failed

64c1339

jacobkim9881 marked this pull request as ready for review July 26, 2024 17:49

jacobkim9881 requested a review from a team as a code owner July 26, 2024 17:49

melvin-bot bot requested review from rushatgabhane and removed request for a team July 26, 2024 17:50

jacobkim9881 added 4 commits July 27, 2024 02:55

canceled null check

ceb7b41

Merge branch '44919' of github.com:jacobkim9881/Expensify-App into 44919

71b5e5d

canceled null check

a52a997

Merge branch '44919' of github.com:jacobkim9881/Expensify-App into 44919

0177edf

rushatgabhane suggested changes Jul 26, 2024

View reviewed changes

fix typecheck, lint not passed

89d1ae1

fix added null check in the script

e1404d0

rushatgabhane approved these changes Jul 29, 2024

View reviewed changes

melvin-bot bot requested a review from Gonals July 29, 2024 20:58

Gonals previously approved these changes Jul 31, 2024

View reviewed changes

build: pulled updates

d5638d5

jacobkim9881 dismissed Gonals’s stale review via d5638d5 July 31, 2024 16:32

jacobkim9881 added 2 commits August 1, 2024 02:27

fix: parameter name edited

f73e6a9

Merge branch 'main' of https://github.com/Expensify/App into 44919

87c6ec9

Merge branch 'main' of https://github.com/Expensify/App into 44919

411cf41

Gonals approved these changes Aug 2, 2024

View reviewed changes

Gonals merged commit 8ebf085 into Expensify:main Aug 2, 2024
14 checks passed

github-actions bot mentioned this pull request Aug 6, 2024

Deploy Checklist: New Expensify 2024-08-06 #46849

Closed

83 tasks

melvin-bot bot mentioned this pull request Aug 7, 2024

[HOLD for payment 2024-08-14] [$250] Tapping Pay button in an invoice crashes the app #44919

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix clicking pay button for invoices raise an null error #46317

fix clicking pay button for invoices raise an null error #46317

jacobkim9881 commented Jul 26, 2024

melvin-bot bot commented Jul 26, 2024

jacobkim9881 commented Jul 26, 2024

rushatgabhane left a comment

jacobkim9881 commented Jul 28, 2024

rushatgabhane commented Jul 28, 2024

jacobkim9881 commented Jul 28, 2024

rushatgabhane left a comment

Gonals commented Jul 31, 2024

jacobkim9881 commented Jul 31, 2024

Gonals commented Aug 2, 2024

jacobkim9881 commented Aug 2, 2024

OSBotify commented Aug 2, 2024

OSBotify commented Aug 6, 2024

OSBotify commented Aug 7, 2024

OSBotify commented Aug 8, 2024

OSBotify commented Aug 8, 2024

fix clicking pay button for invoices raise an null error #46317

fix clicking pay button for invoices raise an null error #46317

Conversation

jacobkim9881 commented Jul 26, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

test1

test2

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 26, 2024

jacobkim9881 commented Jul 26, 2024

rushatgabhane left a comment

Choose a reason for hiding this comment

jacobkim9881 commented Jul 28, 2024

rushatgabhane commented Jul 28, 2024

jacobkim9881 commented Jul 28, 2024

rushatgabhane left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Screenshots/Videos

Gonals commented Jul 31, 2024

jacobkim9881 commented Jul 31, 2024

Gonals commented Aug 2, 2024

jacobkim9881 commented Aug 2, 2024

OSBotify commented Aug 2, 2024

OSBotify commented Aug 6, 2024

OSBotify commented Aug 7, 2024

OSBotify commented Aug 8, 2024

OSBotify commented Aug 8, 2024