-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove popstate listener in popover #46357
Conversation
avoid auto-dismissal issue in some browser
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@dominictb I know that taking screenshots for different platforms takes a lot of time, but please don’t just inspect the website and pretend that’s the screenshots/videos for iOS and Android. 😂 |
On Android/iOS, you can add |
I'm not sure what you mean 🤔 I'm saying you should record video/screenshots correctly for each platform |
@hungvu193 what I mean is the videos are recorded correctly. And in case you wonder how I could manipulate the native platform to record the evidence then this is how I did it. |
Sorry for this confusion but if you record screenshots/videos for a native platform, you should run it on their simulator/emulator, I see you're using web inspector instead. |
@hungvu193 both Android/iOS videos are on simulators. I'm not sure from where did you come into that conclusion. |
You're using mSafari for both mSafari and IOS, and android native for both mChrome and Android right? 🤔 |
@hungvu193 alright, I re-uploaded the iOS and android video including the login step to differentiate. I'm not sure what's the implication/confusion here but it doesn't make sense to me to prolong this conversation without getting anywhere. |
Thanks for understanding. |
Reviewer Checklist
Screenshots/VideosAndroid: mWeb ChromeScreen.Recording.2024-07-29.at.14.14.23.moviOS: Native// running issue iOS: mWeb SafarimSafari.movMacOS: Chrome / SafariWebchrome.movMacOS: DesktopDesktop.mov |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.0.14-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.14-6 🚀
|
avoid auto-dismissal issue in some browser
Details
Fixed Issues
$ #44082
PROPOSAL: #44082 (comment)
Tests
Verify that: Modal with Got it button should appear and user should tap Got it to dismiss the modal
Offline tests
QA Steps
Verify that: Modal with Got it button should appear and user should tap Got it to dismiss the modal
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
compressed_android1.mov.mp4
Android: mWeb Chrome
compressed_android.mov.mp4
iOS: Native
ios.mov
iOS: mWeb Safari
compressed_ios.mp4.mp4
MacOS: Chrome / Safari
compressed_web.mov.mp4
MacOS: Desktop
compressed_web.mov.mp4