Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Composer: add clear command that bypasses the event count" #46626

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

roryabraham
Copy link
Contributor

Reverts #46091

Copy link
Contributor

github-actions bot commented Aug 1, 2024

@roryabraham roryabraham marked this pull request as ready for review August 1, 2024 18:03
@roryabraham roryabraham requested a review from a team as a code owner August 1, 2024 18:03
@roryabraham roryabraham self-assigned this Aug 1, 2024
@melvin-bot melvin-bot bot removed the request for review from a team August 1, 2024 18:04
Copy link

melvin-bot bot commented Aug 1, 2024

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested a review from blimpich August 1, 2024 18:04
@roryabraham
Copy link
Contributor Author

roryabraham commented Aug 1, 2024

merging straight revert without checklists, tested AdHoc w/ applause: https://expensify.slack.com/archives/C9YU7BX5M/p1722531831074969

@roryabraham roryabraham merged commit 7ef4912 into main Aug 1, 2024
12 of 14 checks passed
@roryabraham roryabraham deleted the revert-46091-fix/37896-composer-not-cleared branch August 1, 2024 18:06
@melvin-bot melvin-bot bot added the Emergency label Aug 1, 2024
Copy link

melvin-bot bot commented Aug 1, 2024

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify
Copy link
Contributor

OSBotify commented Aug 1, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Aug 1, 2024
…ser-not-cleared

Revert "Composer: add clear command that bypasses the event count"

(cherry picked from commit 7ef4912)
@OSBotify
Copy link
Contributor

OSBotify commented Aug 1, 2024

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.0.15-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Aug 2, 2024

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.15-9 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@hannojg
Copy link
Contributor

hannojg commented Aug 5, 2024

Opened a new PR with a proper fix here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants