-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Update Sage-Intacct-Troubleshooting.md #46669
Conversation
A preview of your ExpensifyHelp changes have been deployed to https://fa166a12.helpdot.pages.dev ⚡️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do those preview links work? I went to the page for sage-intacct troubleshooting, and all it said was "coming soon"
@tgolen looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Only changes were for documentation so checklists didn't need to be done. |
🚀 Deployed to staging by https://github.com/tgolen in version: 9.0.16-0 🚀
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.16-8 🚀
|
Details
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/412443
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop