Search filters: tax, expense type and tag

[SzymczakJ]

Details

This PR adds Expense Type, tax and Tag filters to Search feature. I decided to put these three filters together because they share the same concept and use the same main component.
There are some files changed that don't belong to Search feature, but it's because I decided to make a small refactor of PolicyTagList, while implementing Tag filter(previous PolicyTagList really confused me).
I refactored Currency filter and Category filter to reuse common component.
I also refactored Search Pages to not use pointless <FullPageNotFoundView shouldShow={false}>

Fixed Issues

$ #46041
$ #46037
$ #46040
PROPOSAL:

Tests

1. Go to advanced Filters page /search/filters
2. Apply tags filter(single value and then multiple values).
3. View results and check if they are filtered out.
4. Do the same for tax rates
5. Expense types are not yet testable because it hasn't got deployed yet.

Offline tests

QA Steps

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

andoird_web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

web_ios.mov

MacOS: Chrome / Safari

web_tag.mov

web_tax.mov

MacOS: Desktop

desktop.mov

[melvin-bot]

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[SzymczakJ]

I'll record videos tomorrow, but the code is ready for C+ review

[luacmartins]

We still have comments to address and lint is failing

[SzymczakJ]

@rayane-djouah fixed comments and bugs that you mentioned. I'm recording videos at the moment.

[rayane-d]

@SzymczakJ - Can we address this comment: #46736 (comment)?

[SzymczakJ]

Sorry for missing that, I've addressed that comment @rayane-djouah

[rayane-d]

Sorry for missing that, I've addressed that comment @rayane-djouah

@SzymczakJ - Sorry, but I'm not seeing any changes made to sanitizeString function, did you forget to push your latest changes?

[rayane-d]

Bug: Can't unselect options from the multiple selection picker:

Screen.Recording.2024-08-12.at.4.30.39.PM.mov

[SzymczakJ]

Damn I fixed both things but forgot to push it. Sorry for that blooper 😅

[rayane-d]

@SzymczakJ @luacmartins
Bug:
If you go to Settings > Troubleshoot > Clear Cache and Restart, and then navigate to the Advanced Filters page, the tags, tax rates, and categories lists appear empty (we are getting them from Onyx only).

We’re currently retrieving tags (for example) for one workspace using the OpenPolicyTagsPage API command and storing them in Onyx when accessing the workspace tags page. However, for the tags filter, we need to retrieve tags across all workspaces. How should we address this issue?

[rayane-d]

LGTM and tests well.
@luacmartins, I think we can address #46736 (comment) and #46736 (comment) in follow-up PRs, as this PR is getting quite large.

[rayane-d]

@luacmartins I've created an issue for #46736 (comment)

[rayane-d]

@SzymczakJ - There are conflicts!

[luacmartins]

I think #46736 (comment) is something we can put on the back burner for now. It's a bit of an edge case. I agree we can tackle the ID shown in the header in a follow up.

[luacmartins]

LGTM

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.20-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[mvtglobally]

@luacmartins Do we need to QA anything here?

[luacmartins]

@mvtglobally not at this time.

[Beamanator]

FYI I believe this was deployed to prod yesterday, from this checklist - #47356